Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pyclient): move code interacting with server to new file #4619

Closed
YpeZ opened this issue Jan 20, 2025 · 1 comment
Closed

chore(pyclient): move code interacting with server to new file #4619

YpeZ opened this issue Jan 20, 2025 · 1 comment
Assignees
Labels
emx2_python_client enhancement New feature or request

Comments

@YpeZ
Copy link
Contributor

YpeZ commented Jan 20, 2025

Issue

The code in client.py is exceeding 1000 lines, making maintenance troublesome at times.
Most of this code is for interacting with a server whilst it is also contains the class with which the users of the Pyclient interact.

Solution

Handling requests, parsing data and other processes that occur behind the scenes should be moved to a new file, e.g. _client.py, such that the client.py only serves for interacting with the user of the package.
This improves maintainability of the code as it makes a clear distinction between the code a user interacts with and code that runs behind the scenes and connects to the server.

Alternatives

No response

Additional context

No response

@YpeZ YpeZ added emx2_python_client enhancement New feature or request labels Jan 20, 2025
@YpeZ YpeZ linked a pull request Feb 10, 2025 that will close this issue
7 tasks
@YpeZ YpeZ self-assigned this Feb 10, 2025
@YpeZ YpeZ removed a link to a pull request Feb 13, 2025
7 tasks
@YpeZ
Copy link
Contributor Author

YpeZ commented Feb 13, 2025

Integrated in other story

@YpeZ YpeZ closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emx2_python_client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant