Skip to content

feat: navigate support data: protocol #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2025
Merged

feat: navigate support data: protocol #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc3bbf
feat: navigate support data: protocol
5unnyWind Jun 10, 2025
31e7400
Merge branch 'v3' into v3
molefrog Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions packages/wouter/src/use-hash-location.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,26 @@ const subscribeToHashUpdates = (callback) => {
const currentHashLocation = () => "/" + location.hash.replace(/^#?\/?/, "");

export const navigate = (to, { state = null, replace = false } = {}) => {
const [hash, search] = to.replace(/^#?\/?/, "").split("?");

const newRelativePath =
location.pathname + (search ? `?${search}` : location.search) + `#/${hash}`;
const oldURL = location.href;
const newURL = new URL(newRelativePath, location.origin).href;
let newURL, newHistoryStatePath;

if (location.protocol === "data:") {
const newHash = "#/" + to.replace(/^#?\/?/, "");
newHistoryStatePath = newHash;
newURL = oldURL.split("#")[0] + newHash;
} else {
const [hash, search] = to.replace(/^#?\/?/, "").split("?");
newHistoryStatePath =
location.pathname +
(search ? `?${search}` : location.search) +
`#/${hash}`;
newURL = new URL(newHistoryStatePath, location.origin).href;
}
Comment on lines +29 to +40
Copy link
Owner

@molefrog molefrog Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR. I've got a theory that if we just change the URL constructor code, we will be able to fix this without handling a special case when the protocol is :data

Image

Something like:

    const [hash, search] = to.replace(/^#?\/?/, "").split("?");

    const newRelativePath =
      location.pathname + (search ? `?${search}` : location.search) + `#/${hash}`;
    const oldURL = location.href;

    // Works for ALL protocols including data:
    const url = new URL(location.href);
    url.hash = `/${hash}`;
    if (search) url.search = search;
    const newURL = url.href;

Could you please check if this is something we could use?

Copy link
Owner

@molefrog molefrog Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nevermind. I'm going to merge this and refactor separately. Thanks!


if (replace) {
history.replaceState(state, "", newRelativePath);
history.replaceState(state, "", newHistoryStatePath);
} else {
history.pushState(state, "", newRelativePath);
history.pushState(state, "", newHistoryStatePath);
}

const event =
Expand Down
27 changes: 27 additions & 0 deletions packages/wouter/test/use-hash-location.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,33 @@ test("defines a custom way of rendering link hrefs", () => {
expect(getByTestId("link")).toHaveAttribute("href", "#/app");
});

test("handles navigation with data: protocol", async () => {
const originalHref = location.href;
location.href = "data:text/html,content";

expect(location.protocol).toBe("data:");

const { result } = renderHook(() => useHashLocation());
const [, navigate] = result.current;
const initialHistoryLength = history.length;

await waitForHashChangeEvent(() => {
navigate("/new-path");
});

expect(location.hash).toBe("#/new-path");
expect(history.length).toBe(initialHistoryLength + 1);

await waitForHashChangeEvent(() => {
navigate("/another-path", { replace: true });
});

expect(location.hash).toBe("#/another-path");
expect(history.length).toBe(initialHistoryLength + 1);

location.href = originalHref;
});

test("interacts properly with the history stack", () => {
const { result } = renderHook(() => useHashLocation());
const [, navigate] = result.current;
Expand Down
Loading