fix: skip blacklisted actions in auto-alias regeneration #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace throw ServiceNotFoundError with return statement when checking blacklist in regenerateAutoAliases method. This prevents server from crashing and allows auto-alias regeneration to continue with other actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Server crashes with
ServiceNotFoundErrorwhen blacklisted action is found during auto-alias regeneration.Root Cause
In
regenerateAutoAliasesmethod, when checking if an action is in the blacklist, the code throwsServiceNotFoundErrorinstead of skipping the action. This causes the entire regeneration process to fail and crash the server.Solution
Replace
throw new ServiceNotFoundError(...)withreturnstatement when blacklist check fails during auto-alias regeneration. This allows the process to skip blacklisted actions and continue with other actions.Changes
src/index.jsline 1778: changed from throwing error to returning early