Skip to content

Commit 171d83c

Browse files
authored
fix: fix warning on startup windows (#38)
1 parent c8282f0 commit 171d83c

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

kid.go

+8-4
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"net/url"
88
"os"
99
"reflect"
10+
"runtime"
1011
"sync"
1112

1213
htmlrenderer "github.com/mojixcoder/kid/html_renderer"
@@ -43,7 +44,7 @@ type (
4344
}
4445
)
4546

46-
// Version is the Kid version.
47+
// Version of Kid.
4748
const Version string = "0.1.0"
4849

4950
// New returns a new instance of Kid.
@@ -71,7 +72,7 @@ func New() *Kid {
7172
//
7273
// Specifying an address is optional. Default address is :2376.
7374
func (k *Kid) Run(address ...string) error {
74-
addr := resolveAddress(address)
75+
addr := resolveAddress(address, runtime.GOOS)
7576

7677
k.printDebug(os.Stdout, "Kid version %s\n", Version)
7778
k.printDebug(os.Stdout, "Starting server at %s\n", addr)
@@ -258,9 +259,12 @@ func getPath(u *url.URL) string {
258259
}
259260

260261
// resolveAddress returns the address which server will run on.
261-
func resolveAddress(addresses []string) string {
262+
func resolveAddress(addresses []string, goos string) string {
262263
if len(addresses) == 0 {
263-
return ":2376"
264+
if goos == "windows" {
265+
return "127.0.0.1:2376"
266+
}
267+
return "0.0.0.0:2376"
264268
}
265269
return addresses[0]
266270
}

kid_test.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -617,11 +617,15 @@ func TestKid_printDebug(t *testing.T) {
617617
}
618618

619619
func TestResolveAddress(t *testing.T) {
620-
addr := resolveAddress([]string{})
620+
goos := "windows"
621+
addr := resolveAddress([]string{}, goos)
622+
assert.Equal(t, "127.0.0.1:2376", addr)
621623

622-
assert.Equal(t, ":2376", addr)
624+
goos = "linux"
625+
addr = resolveAddress([]string{}, goos)
626+
assert.Equal(t, "0.0.0.0:2376", addr)
623627

624-
addr = resolveAddress([]string{":2377", "2378"})
628+
addr = resolveAddress([]string{":2377", ":2378"}, goos)
625629
assert.Equal(t, ":2377", addr)
626630
}
627631

0 commit comments

Comments
 (0)