Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Allow match_weights_chart with model json only #2632

Open
RossKen opened this issue Feb 20, 2025 · 0 comments · May be fixed by #2641
Open

[FEAT] Allow match_weights_chart with model json only #2632

RossKen opened this issue Feb 20, 2025 · 0 comments · May be fixed by #2641
Labels
charts enhancement New feature or request

Comments

@RossKen
Copy link
Contributor

RossKen commented Feb 20, 2025

Is your proposal related to a problem?

Currently to generate a match_weights_chart a linker (with data) is required. If I am trying to visualise a trained model which has been saved as a json, this feels unnecessary.

My current workaround is to create an empty dataframe with the correct column nomes, which isn't ideal.

Describe the solution you'd like

Alternative to linker.visualisations.match_weights_chart that is not part of the linker that allows you to pass a trained model. For example:

from splink.visualisations import match_weights_chart

chart = match_weights_chart("model.json")

Similar to the clustering methods that live outside of the linker

Describe alternatives you've considered

Additional context

@RossKen RossKen added enhancement New feature or request charts labels Feb 20, 2025
@RossKen RossKen linked a pull request Feb 28, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
charts enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant