Feat/py3.7 (#35)

* refactor to remove := operator

* rm python 3.8+ requirement from docs

Co-authored-by: Saumil Dave <[email protected]>

Author: saumil-d

CONTRIBUTING.adoc

@@ -87,7 +87,7 @@ Clone the repository:
 
 - `$ git clone https://github.com/modzy/sdk-python.git`
 
-Setup a virtual environment from the local git directory (NOTE: Requires Python >= 3.8):
+Setup a virtual environment from the local git directory:
 
 - `$ conda create --name VIRTUAL_ENVIRON_NAME --file requirements_dev.txt -c conda-forge python=3.9`
 or for non-conda python distros:

README.md

@@ -20,7 +20,7 @@
 
 [![installation](https://github.com/modzy/sdk-python/raw/main/install.gif)](https://asciinema.org/a/0lHaPxvXTrPTp1Bb6bNea1ZCG)
 
-Use the package manager [pip](https://pip.pypa.io/en/stable/) to install the SDK (NOTE: Requires Python >= 3.8):
+Use the package manager [pip](https://pip.pypa.io/en/stable/) to install the SDK:
 
 - `$ pip install modzy-sdk`
 

modzy/_util.py

@@ -51,12 +51,16 @@ def file_to_chunks(file_like, chunk_size):
     if hasattr(file, 'seekable') and file.seekable():
         file.seek(0)
 
-    while chunk := file.read(chunk_size):
-        if not isinstance(chunk, bytes):
+    while True:
+        chunk = file.read(chunk_size)
+        if not chunk:
+            break
+        elif not isinstance(chunk, bytes):
             raise TypeError("the file object's 'read' function must return bytes not {}; "
                             "files should be opened using binary mode 'rb'"
                             .format(type(chunk).__name__))
-        yield chunk
+        else:
+            yield chunk
 
     if should_close:
         file.close()