Add role limit in thread creation embed fixes #191

Author: kyb3r

core/thread.py

@@ -648,14 +648,24 @@ def _format_info_embed(self, user, log_url, log_count, color):
 
         role_names = ''
         if member:
-            separate_server = self.bot.guild != self.bot.modmail_guild
-            roles = sorted(member.roles, key=lambda c: c.position)
-            if separate_server:
-                role_names = ', '.join(r.name for r in roles
-                                       if r.name != "@everyone")
-            else:
-                role_names = ' '.join(r.mention for r in roles
-                                      if r.name != "@everyone")
+            sep_server = self.bot.using_multiple_server_setup
+            seperator = ', ' if sep_server else ' '
+
+            roles = []
+
+            for role in sorted(member.roles, key=lambda r: r.position):
+                if role.name == '@everyone':
+                    continue
+
+                fmt = role.name if sep_server else role.mention
+                roles.append(fmt)
+
+                if len(seperator.join(roles)) > 1000:
+                    roles.pop()
+                    roles.append('...')
+                    break
+                
+            role_names = seperator.join(roles)
 
         embed = discord.Embed(color=color,
                               description=user.mention,