Fixed a typo with convert_emoji

Author: Taaku18

bot.py

@@ -439,11 +439,9 @@ async def convert_emoji(self, name):
 
         if name not in UNICODE_EMOJI:
             try:
-                return await converter.convert(
-                    ctx, sent_emoji.strip(':')
-                )
+                name = await converter.convert(ctx, name.strip(':'))
             except commands.BadArgument:
-                pass
+                logger.warning(f'{name} is not a valid emoji.')
         return name
 
     async def retrieve_emoji(self):
@@ -456,7 +454,6 @@ async def retrieve_emoji(self):
         sent_emoji = self.config.get('sent_emoji', '✅')
         blocked_emoji = self.config.get('blocked_emoji', '🚫')
 
-
         if sent_emoji not in UNICODE_EMOJI:
             try:
                 sent_emoji = await converter.convert(
@@ -660,18 +657,19 @@ async def on_raw_reaction_add(self, payload):
 
         channel = self.get_channel(payload.channel_id)
 
-        if not channel: # dm channel not in internal cache
+        if not channel:  # dm channel not in internal cache
             _thread = await self.threads.find(recipient=user)
             if not _thread:
                 return
             channel = await _thread.recipient.create_dm()
 
-        message = await channel.get_message(payload.message_id) # TODO: change to fetch_message (breaking change in d.py)
+        # TODO: change to fetch_message (breaking change in d.py)
+        message = await channel.get_message(payload.message_id)
         reaction = payload.emoji
 
         close_emoji = await self.convert_emoji(self.config.get('close_emoji', '🔒'))
 
-        if isinstance(channel, discord.DMChannel) and str(reaction) == str(close_emoji): # closing thread
+        if isinstance(channel, discord.DMChannel) and str(reaction) == str(close_emoji):  # closing thread
             thread = await self.threads.find(recipient=user)
             ts = message.embeds[0].timestamp if message.embeds else None
             if thread and ts == thread.channel.created_at: 
@@ -689,7 +687,6 @@ async def on_raw_reaction_add(self, payload):
                     if msg.id == int(message_id):
                         await msg.add_reaction(reaction)
 
-
     async def on_guild_channel_delete(self, channel):
         if channel.guild != self.modmail_guild:
             return

core/models.py

@@ -140,6 +140,10 @@ def main_color(self) -> typing.Union[Color, int]:
     async def process_modmail(self, message: Message) -> None:
         raise NotImplementedError
 
+    @abc.abstractmethod
+    async def convert_emoji(self, name: str) -> str:
+        raise NotImplementedError
+
     @staticmethod
     @abc.abstractmethod
     def overwrites(ctx: commands.Context) -> dict: