Remove redundant check

mnvr · mnvr · commit 6f740b7bade9 · 2023-12-17T08:01:14.000+05:30
diff --git a/16.swift b/16.swift
@@ -53,15 +53,13 @@ func energized(by beam: Beam) -> Int {
 }
 
 func trace(beam: Beam, visited: inout Set<Beam>) {
-    if visited.contains(beam) {
-        return
-    }
-
     var (beam, bt) = (beam, beam)
     var next: [Beam] = []
 
     while isInBounds(beam) {
-        visited.insert(beam)
+        if !visited.insert(beam).inserted {
+            break
+        }
 
         switch item(at: beam) {
         case .vbar where beam.isHorizontal:
@@ -89,7 +87,7 @@ func trace(beam: Beam, visited: inout Set<Beam>) {
         }
     }
 
-    next.filter(isInBounds).forEach { trace(beam: $0, visited: &visited) }
+    next.forEach { trace(beam: $0, visited: &visited) }
 }
 
 func isInBounds(_ beam: Beam) -> Bool {

Original file line number	Diff line number	Diff line change
`@@ -53,15 +53,13 @@ func energized(by beam: Beam) -> Int {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`func trace(beam: Beam, visited: inout Set<Beam>) {`
`56`		`- if visited.contains(beam) {`
`57`		`- return`
`58`		`- }`
`59`		`-`
`60`	`56`	`var (beam, bt) = (beam, beam)`
`61`	`57`	`var next: [Beam] = []`
`62`	`58`
`63`	`59`	`while isInBounds(beam) {`
`64`		`- visited.insert(beam)`
	`60`	`+ if !visited.insert(beam).inserted {`
	`61`	`+ break`
	`62`	`+ }`
`65`	`63`
`66`	`64`	`switch item(at: beam) {`
`67`	`65`	`case .vbar where beam.isHorizontal:`
`@@ -89,7 +87,7 @@ func trace(beam: Beam, visited: inout Set<Beam>) {`
`89`	`87`	`}`
`90`	`88`	`}`
`91`	`89`
`92`		`- next.filter(isInBounds).forEach { trace(beam: $0, visited: &visited) }`
	`90`	`+ next.forEach { trace(beam: $0, visited: &visited) }`
`93`	`91`	`}`
`94`	`92`
`95`	`93`	`func isInBounds(_ beam: Beam) -> Bool {`