allow to derpmap iniitalization if it fails

In case network is not available or firewall is blocking outgoing
connections and we cannot get best derp region, do not crash and
allow to retry the whole process.

Author: mmozeiko

ScreenBuddy.c

@@ -274,7 +274,7 @@ static DWORD CALLBACK Buddy_GetBestDerpRegionThread(LPVOID Arg)
 	uint8_t Buffer[64 * 1024];
 	size_t BufferSize = Buddy_DownloadDerpMap(Buddy->HttpSession, Buffer, sizeof(Buffer));
 
-	JsonObject* Json = JsonObject_Parse((char*)Buffer, (int)BufferSize);
+	JsonObject* Json = BufferSize ? JsonObject_Parse((char*)Buffer, (int)BufferSize) : NULL;
 	JsonObject* Regions = JsonObject_GetObject(Json, JsonCSTR("Regions"));
 	JsonIterator* Iterator = JsonObject_GetIterator(Regions);
 	if (Iterator)
@@ -2373,6 +2373,7 @@ static INT_PTR CALLBACK Buddy_DialogProc(HWND Dialog, UINT Message, WPARAM WPara
 
 			SetFocus(GetDlgItem(Dialog, BUDDY_ID_SHARE_COPY));
 
+			Buddy->DialogWindow = Dialog;
 			Buddy->DerpRegionThread = CreateThread(NULL, 0, &Buddy_GetBestDerpRegionThread, Buddy, 0, NULL);
 			Assert(Buddy->DerpRegionThread);
 		}
@@ -2485,18 +2486,28 @@ static INT_PTR CALLBACK Buddy_DialogProc(HWND Dialog, UINT Message, WPARAM WPara
 		}
 		else if (Control == BUDDY_ID_SHARE_NEW)
 		{
-			DerpNet_CreateNewKey(&Buddy->MyPrivateKey);
-			DerpNet_GetPublicKey(&Buddy->MyPrivateKey, &Buddy->MyPublicKey);
+			if (Buddy->DerpRegion == 0)
+			{
+				Edit_SetText(GetDlgItem(Dialog, BUDDY_ID_SHARE_KEY), L"...initializing...");
 
-			DATA_BLOB BlobInput = { sizeof(Buddy->MyPrivateKey), Buddy->MyPrivateKey.Bytes };
-			DATA_BLOB BlobOutput;
-			BOOL Protected = CryptProtectData(&BlobInput, NULL, NULL, NULL, NULL, CRYPTPROTECT_UI_FORBIDDEN, &BlobOutput);
-			Assert(Protected);
+				Buddy->DerpRegionThread = CreateThread(NULL, 0, &Buddy_GetBestDerpRegionThread, Buddy, 0, NULL);
+				Assert(Buddy->DerpRegionThread);
+			}
+			else
+			{
+				DerpNet_CreateNewKey(&Buddy->MyPrivateKey);
+				DerpNet_GetPublicKey(&Buddy->MyPrivateKey, &Buddy->MyPublicKey);
 
-			WritePrivateProfileStructW(BUDDY_CONFIG, L"DerpPrivateKey", BlobOutput.pbData, BlobOutput.cbData, Buddy->ConfigPath);
-			LocalFree(BlobOutput.pbData);
+				DATA_BLOB BlobInput = { sizeof(Buddy->MyPrivateKey), Buddy->MyPrivateKey.Bytes };
+				DATA_BLOB BlobOutput;
+				BOOL Protected = CryptProtectData(&BlobInput, NULL, NULL, NULL, NULL, CRYPTPROTECT_UI_FORBIDDEN, &BlobOutput);
+				Assert(Protected);
 
-			Dialog_ShowShareKey(GetDlgItem(Dialog, BUDDY_ID_SHARE_KEY), Buddy->DerpRegion, &Buddy->MyPublicKey);
+				WritePrivateProfileStructW(BUDDY_CONFIG, L"DerpPrivateKey", BlobOutput.pbData, BlobOutput.cbData, Buddy->ConfigPath);
+				LocalFree(BlobOutput.pbData);
+
+				Dialog_ShowShareKey(GetDlgItem(Dialog, BUDDY_ID_SHARE_KEY), Buddy->DerpRegion, &Buddy->MyPublicKey);
+			}
 		}
 		else if (Control == BUDDY_ID_CONNECT_PASTE)
 		{
@@ -2561,15 +2572,16 @@ static INT_PTR CALLBACK Buddy_DialogProc(HWND Dialog, UINT Message, WPARAM WPara
 
 	case BUDDY_WM_BEST_REGION:
 	{
+		WaitForSingleObject(Buddy->DerpRegionThread, INFINITE);
+		CloseHandle(Buddy->DerpRegionThread);
+
 		if (WParam == 0)
 		{
-			MessageBoxW(Buddy->DialogWindow, L"Cannot determine best DERP region!", L"Error", MB_ICONERROR);
-			ExitProcess(0);
+			Edit_SetText(GetDlgItem(Dialog, BUDDY_ID_SHARE_KEY), L"Error!");
+			MessageBoxW(Buddy->DialogWindow, L"Cannot determine best DERP region! Please check your\ninternet connection and retry new code generation.", BUDDY_TITLE, MB_ICONERROR);
+			return 0;
 		}
-
 		Buddy->DerpRegion = (uint32_t)WParam;
-		WaitForSingleObject(Buddy->DerpRegionThread, INFINITE);
-		CloseHandle(Buddy->DerpRegionThread);
 
 		wchar_t DerpRegionText[128];
 		StrFormat(DerpRegionText, L"%u", Buddy->DerpRegion);

external/WindowsJson.h

@@ -157,7 +157,7 @@ JsonIterator* JsonObject_GetIterator(JsonObject* Object)
 	__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue* Iterator = NULL;
 
 	__FIIterable_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue* Iterable;
-	if (SUCCEEDED(__x_ABI_CWindows_CData_CJson_CIJsonObject_QueryInterface(Object, &IID_IMap_IJsonValue, (void**)&Iterable)))
+	if (Object && SUCCEEDED(__x_ABI_CWindows_CData_CJson_CIJsonObject_QueryInterface(Object, &IID_IMap_IJsonValue, (void**)&Iterable)))
 	{
 		HR(__FIIterable_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_First(Iterable, &Iterator));
 
@@ -180,7 +180,7 @@ HSTRING JsonIterator_GetKey(JsonIterator* Iterator)
 	HSTRING Result = NULL;
 
 	__FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue* Current;
-	if (SUCCEEDED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Current(Iterator, &Current)))
+	if (Iterator && SUCCEEDED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Current(Iterator, &Current)))
 	{
 		HR(__FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Key(Current, &Result));
 		__FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_Release(Current);
@@ -194,7 +194,7 @@ JsonObject* JsonIterator_GetValue(JsonIterator* Iterator)
 	JsonObject* Result = NULL;
 
 	__FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue* Current;
-	if (SUCCEEDED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Current(Iterator, &Current)))
+	if (Iterator && SUCCEEDED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Current(Iterator, &Current)))
 	{
 		__x_ABI_CWindows_CData_CJson_CIJsonValue* Value;
 		HR(__FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_get_Value(Current, &Value));
@@ -210,7 +210,7 @@ JsonObject* JsonIterator_GetValue(JsonIterator* Iterator)
 bool JsonIterator_Next(JsonIterator* Iterator)
 {
 	boolean Result;
-	if (FAILED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_MoveNext(Iterator, &Result)))
+	if (Iterator && FAILED(__FIIterator_1___FIKeyValuePair_2_HSTRING_Windows__CData__CJson__CIJsonValue_MoveNext(Iterator, &Result)))
 	{
 		Result = 0;
 	}