Skip to content

Commit d713fb9

Browse files
committed
Improved order of memory releases
1 parent a268b20 commit d713fb9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/postgresql_stubs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -536,9 +536,9 @@ CAMLprim value PQexecParams_stub(
536536
(nparams == 0)
537537
? PQexec(conn, query)
538538
: PQexecParams(conn, query, nparams, NULL, params, lengths, formats, 0);
539-
free(query);
540-
free_params(params, nparams);
541539
free_binary_params(formats, lengths);
540+
free_params(params, nparams);
541+
free(query);
542542
caml_leave_blocking_section();
543543
CAMLreturn(alloc_result(res, np_cb));
544544
}
@@ -589,8 +589,8 @@ CAMLprim value PQexecPrepared_stub(
589589
caml_enter_blocking_section();
590590
res = PQexecPrepared(conn, stm_name, nparams, params, lengths, formats, 0);
591591
free(stm_name);
592-
free_params(params, nparams);
593592
free_binary_params(formats, lengths);
593+
free_params(params, nparams);
594594
caml_leave_blocking_section();
595595
CAMLreturn(alloc_result(res, np_cb));
596596
#else
@@ -750,8 +750,8 @@ CAMLprim value PQsendQueryParams_stub(
750750
? PQsendQuery(conn, query)
751751
: PQsendQueryParams(
752752
conn, query, nparams, NULL, params, lengths, formats, 0);
753-
free_params_shallow(params, nparams);
754753
free_binary_params(formats, lengths);
754+
free_params_shallow(params, nparams);
755755
return Val_int(res);
756756
}
757757

0 commit comments

Comments
 (0)