Skip to content

Spaces in machine name breaks Dropkick tasks #12

@mmooney

Description

@mmooney

If there is a space in the machine name (or anywhere else that would impact the local run path), it will break any tasks that call dropkick (dk.exe). This is because when the settings/deployment paths are passed into dk.exe, even if you wrap them in quotes, it will lose track of the quotes and garble the command line.

This is described here: chucknorris/dropkick#34. There was a PR submitted to fix it, but it seems like it still causes the issue (the PR added back double-quotes, but even passing double quotes down to underlying Magnum library doesn't solve the issue, Magnum still loses track of the double quotes).

Another possible solution is to force dk.exe to not use full paths, but use relative ones instead. This is possible, but kinda hacky. Ideally we can get dk.exe to handle the double quotes more cleanly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions