Skip to content

Commit e077139

Browse files
committed
Correct a couple of minor things
1 parent 17382e4 commit e077139

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ Note the following limitations of this early version of the plugin:
3232
## Motivation
3333

3434
I like using the [obsidian-plotly](https://github.com/Dmytro-Shulha/obsidian-plotly) plugin to render interactive figures in my notes. The user pastes Plotly JSON inside a code block, which is displayed as the rendered figure.
35-
However, when editing the note or interacting with the plot, the code block sometimes collapses back into its unrendered form. This causes the note to lag, to the point of unusability.
35+
However, when editing the note or interacting with the plot, the code block sometimes collapses back into its unrendered form. This sometimes causes the editor to lag to the point of unusability.
3636

3737
Thankfully:
38-
- If the code block is placed in a standalone note which is then embedded, the embed renders well and does not collapse back into editable JSON.
39-
- We usually do not need to edit the JSON directly, and when we do, it is probably easier to do so when they are in a separate note and not expanding/collapsing thousands of characters inside an existing view.
38+
- If the code block is placed in a standalone note which is then embedded, it renders well as an embed and does not collapse back into editable JSON.
39+
- We usually do not need to edit the JSON directly, and if we do, it is probably easier to do so when they are in a separate note and not expanding/collapsing thousands of characters inside an existing view.
4040
- This allows us to treat Plotly figures like other (e.g. image) attachments.
4141

42-
However, it is effortful to manually create and embed these notes. Acknowledging that similar use cases may benefit from automation, and wanting to try writing an Obsidian plugin for the first time, I wrote this plugin.
42+
However, it is effortful to manually create and embed these notes. Acknowledging that similar use cases may benefit from automation, and wanting to try writing an Obsidian plugin for the first time, I wrote this one.
4343

4444
## Acknowledgments
4545

main.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export default class PasteAsEmbed extends Plugin {
128128
async onload() { // Configure resources needed by the plugin.
129129
await this.loadSettings();
130130
// This adds a settings tab so the user can configure various aspects of the plugin
131-
this.addSettingTab(new SampleSettingTab(this.app, this));
131+
this.addSettingTab(new PasteAsEmbedSettingTab(this.app, this));
132132

133133
this.adapter = this.app.vault.adapter as FileSystemAdapter;
134134

@@ -176,7 +176,7 @@ export interface PasteRule {
176176
}
177177

178178

179-
class SampleSettingTab extends PluginSettingTab {
179+
class PasteAsEmbedSettingTab extends PluginSettingTab {
180180
plugin: PasteAsEmbed;
181181
rulesEl: HTMLDivElement;
182182

0 commit comments

Comments
 (0)