Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full offline use #75

Open
larueli opened this issue Apr 6, 2023 · 3 comments
Open

Full offline use #75

larueli opened this issue Apr 6, 2023 · 3 comments

Comments

@larueli
Copy link

larueli commented Apr 6, 2023

Hello !

In this line

<link rel="icon" type="image/png" href="https://chatanalytics.app/favicon.png">
, we still refer to your main server to get the favicon, or we should use the current server we deployed ourselves (user IP not leaked to your servers).

<link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;500;600&display=swap" rel="stylesheet">
we refer to external ressources, or we could serve them locally (better privacy).

If you agree I can open a PR and try to fix that.

@hopperelec
Copy link
Contributor

hopperelec commented Apr 6, 2023

The favicon I definitely agree with, it would also allow replacing the favicon by just replacing a file, but I personally prefer to use Google APIs for stuff like fonts because Google's servers are likely to be faster (although minimally) than your own

@mlomb
Copy link
Owner

mlomb commented Apr 7, 2023

I personally don't bother having those requests, but I get that some people may don't like it.


About the icon:

  • In the app: we can just change the absolute path to just /favicon.png, since it will be hosted alongside it.
  • In the report: Maybe we can hardcode the icon with base64? I can't find information about browser support for this 🤔 and I prefer not to risk it.

About the font, embedding that into the report would bloat the HTML, also it would not be a clean solution. Also I agree with @hopperelec.

@hopperelec
Copy link
Contributor

I think there's a few places where https://chatanalytics.app/ is included in the code, regardless of where it is actually hosted. It could be useful to make this a variable which defaults to http://localhost:8080/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants