Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEPS config yaml missing from datastore_examples directory #121

Open
sadamov opened this issue Feb 11, 2025 · 3 comments
Open

MEPS config yaml missing from datastore_examples directory #121

sadamov opened this issue Feb 11, 2025 · 3 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@sadamov
Copy link
Collaborator

sadamov commented Feb 11, 2025

I am pretty sure that we deleted the meps datastore config yaml file. But given the README we would expect the user to find it there:

Image

Solution is to add it back, I suppose.

@sadamov sadamov changed the title MEPS config yaml missing from test_example directory MEPS config yaml missing from datastore_examples directory Feb 11, 2025
@sadamov sadamov added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 11, 2025
@leifdenby
Copy link
Member

I wasn't quite sure where to put the datastore yaml. Currently, it included in the .tar.gz-file with the MEPS example data (full path: https://object-store.os-api.cci1.ecmwf.int/mllam-testdata/neural-lam/npy/meps_example_reduced.v0.3.0.tar.gz). Sorry if this unclear...

You can see in the end of this notebook how I write this datastore yaml config: https://github.com/mllam/mllam-testdata/blob/main/notebooks/reduced_meps_dataset.ipynb

Are you suggesting this datastore config should instead be in the neural-lam repo?

@leifdenby
Copy link
Member

Oh I realise now. The README is referring to something that doesn't exist until the tests have been run once 😄 that's a bit weird...

@sadamov
Copy link
Collaborator Author

sadamov commented Feb 11, 2025

Yes, that is the only confusing part. A fresh git clone will not contain the files referenced in the README. Explaining this behavior in the readme could already be sufficient 👍 But if someone is just browsing the repo on github.com they won't see the example config...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants