Skip to content

Commit 32d8eff

Browse files
fix: Build failure for SPM (getsentry#1284)
The build failed for users including the SDK via SPM. The CI should check such errors, but it didn't treat warnings as errors. This is fixed now by treating warnings as errors and including the missing header file in the umbrella header. Fixes getsentryGH-1283
1 parent 2cffe8e commit 32d8eff

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## Unreleased
44

5+
- fix: Build failure for SPM (#1284)
56
- fix: Set app state on main thread when terminating (#1272)
67

78
## 7.2.2

Samples/macOS-SPM-CommandLine/Package.swift

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ let package = Package(
1212
targets: [
1313
.target(
1414
name: "macOS-SPM-CommandLine",
15-
dependencies: ["Sentry"])
15+
dependencies: ["Sentry"],
16+
swiftSettings: [
17+
.unsafeFlags(["-warnings-as-errors"])
18+
])
1619
]
1720
)

Sentry.xcodeproj/project.pbxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@
293293
7B6D98ED24C703F8005502FA /* Async.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7B6D98EC24C703F8005502FA /* Async.swift */; };
294294
7B7A30C624B48321005A4C6E /* SentryCrashAdapter.h in Headers */ = {isa = PBXBuildFile; fileRef = 7B7A30C524B48321005A4C6E /* SentryCrashAdapter.h */; };
295295
7B7A30C824B48389005A4C6E /* SentryCrashAdapter.m in Sources */ = {isa = PBXBuildFile; fileRef = 7B7A30C724B48389005A4C6E /* SentryCrashAdapter.m */; };
296-
7B7A599526B692540060A676 /* SentryScreenFrames.h in Headers */ = {isa = PBXBuildFile; fileRef = 7B7A599426B692540060A676 /* SentryScreenFrames.h */; };
296+
7B7A599526B692540060A676 /* SentryScreenFrames.h in Headers */ = {isa = PBXBuildFile; fileRef = 7B7A599426B692540060A676 /* SentryScreenFrames.h */; settings = {ATTRIBUTES = (Public, ); }; };
297297
7B7A599726B692F00060A676 /* SentryScreenFrames.m in Sources */ = {isa = PBXBuildFile; fileRef = 7B7A599626B692F00060A676 /* SentryScreenFrames.m */; };
298298
7B7D872C2486480B00D2ECFF /* SentryStacktraceBuilder.h in Headers */ = {isa = PBXBuildFile; fileRef = 7B7D872B2486480B00D2ECFF /* SentryStacktraceBuilder.h */; };
299299
7B7D872E2486482600D2ECFF /* SentryStacktraceBuilder.m in Sources */ = {isa = PBXBuildFile; fileRef = 7B7D872D2486482600D2ECFF /* SentryStacktraceBuilder.m */; };

Sources/Sentry/Public/Sentry.h

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
3434
#import "SentrySampleDecision.h"
3535
#import "SentrySamplingContext.h"
3636
#import "SentryScope.h"
37+
#import "SentryScreenFrames.h"
3738
#import "SentrySdkInfo.h"
3839
#import "SentrySerializable.h"
3940
#import "SentrySession.h"

0 commit comments

Comments
 (0)