Skip to content

Add missing constraints to TransactionBuilderStep #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
euonymos opened this issue Nov 8, 2024 · 2 comments
Open

Add missing constraints to TransactionBuilderStep #5

euonymos opened this issue Nov 8, 2024 · 2 comments

Comments

@euonymos
Copy link

euonymos commented Nov 8, 2024

Some constraints are missing in the TransactionBuilderStep:

  • signatures
  • validity intervals
  • reference an output (?)
  • not be valid (?)
@klntsky
Copy link
Contributor

klntsky commented Jan 18, 2025

I suggest not implementing any constraints that don't automate anything but rather just attach data to the tx body. We did that in the past and it was just overengineering. Lenses or even pure tx body updates are just fine

@euonymos
Copy link
Author

From the user's perspective, they are the same. Additionally, it's expected since there is no comment on why some bits are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants