Tested TxBuilder.createGcFsTx and it doesn't work for non-present signers (bpi again)

Author: bladyjoker

coop-pab/app/Coop/Cli/TxBuilderGrpc.hs

@@ -98,8 +98,9 @@ txBuilderService opts = do
                       ( \rawTx ->
                           return $
                             defMessage
-                              & success . mintFsTx . cborBase16 .~ rawTx
                               & info .~ info'
+                              & Proto.TxBuilderService.error . otherErr . msg .~ "wuasapp"
+                              & success . mintFsTx . cborBase16 .~ rawTx
                       )
                       mayRawTx
                 )

coop-pab/aux.sh

@@ -9,9 +9,9 @@ function generate-keys {
 
 function start-cluster {
     # As specified in resources/pabConfig.yaml
-    rm -fr .wallets
-    rm -fr .local-cluster
-    mkdir .wallet
+    rm -fR .wallets
+    rm -fR .local-cluster
+    mkdir .wallets
     mkdir .local-cluster
     mkdir .local-cluster/txs
     mkdir .local-cluster/scripts
@@ -95,7 +95,7 @@ function coop-mint-fs {
     {
         "factStatements": [
             {
-                "fsId": "eW==",
+                "fsId": "YXNkCg==",
                 "gcAfter": {
                     "extended": "NEG_INF"
                 },
@@ -111,8 +111,26 @@ function coop-mint-fs {
 
 EOF
            )
-    rawTx=$(echo $resp | jq '.mintFsSuccess.mintFsTx | .cborHex = .cborBase16 | del(.cborBase16) | .description = "" | .type = "Tx BabbageEra"')
-    echo $resp | jq '.mintFsSuccess.alreadyPublished'
+    rawTx=$(echo $resp | jq '.success.mintFsTx | .cborHex = .cborBase16 | del(.cborBase16) | .description = "" | .type = "Tx BabbageEra"')
+    echo $resp | jq '.info'
+    echo $resp | jq '.error'
+    echo $rawTx > .coop-pab-cli/signed
+}
+
+function coop-gc-fs {
+    make-exports
+    resp=$(grpcurl -insecure -import-path ../coop-proto -proto ../coop-proto/tx-builder-service.proto -d @ localhost:5081 coop.TxBuilder/createGcFsTx <<EOF
+    {
+        "fsIds": ["eW==", "YXNkCg=="],
+        "submitter": {
+            "base16": "$SUBMITTER_WALLET"
+        }
+    }
+
+EOF
+        )
+    rawTx=$(echo $resp | jq '.success.gcFsTx | .cborHex = .cborBase16 | del(.cborBase16) | .description = "" | .type = "Tx BabbageEra"')
+    echo $resp | jq '.info'
     echo $resp | jq '.error'
     echo $rawTx > .coop-pab-cli/signed
 }

coop-pab/src/Coop/Pab.hs

@@ -519,8 +519,14 @@ mkPublishingSpec coopDeployment authenticators req = do
       authOut <- Map.toList authOuts
       return (batch, authOut, authWallet, ivTo . cert'validity . auth'certDatum $ batch)
 
+-- TODO: Security Vulnerability: Sign for me!
+-- If the user supplies a Pkh that is either an Authenticator, God, Cert redeemer or Fee
+-- BPI will submit successfully as it has all these wallets in its key store.
+-- THis is due to how 'just signing' actually works in BPI.
 runMintFsTx :: CoopDeployment -> [PaymentPubKeyHash] -> (Value, PaymentPubKeyHash) -> (Bool, Integer) -> CreateMintFsTxReq -> Contract w s Text (Maybe TxId, MintFsInfo)
 runMintFsTx coopDeployment authenticators feeSpec (submit, minutes) req = do
+  self <- PaymentPubKeyHash <$> toCardanoC (req ^. submitter)
+  when (self `elem` authenticators) (throwError "Must have a Submitter that's not an Authenticator (TODO: Fix systematically)")
   (mayPublishingSpec, info) <- mkPublishingSpec coopDeployment authenticators req
   maybe
     (return (Nothing, info))

coop-proto/tx-builder-service.proto

@@ -23,9 +23,9 @@ message CreateMintFsTxResp {
     Error error = 1;
     // Successful Fact Statement Minting message
     MintFsSuccess success = 2;
-    // Information about the processing of the request
-    MintFsInfo info = 3;
   }
+  // Information about the processing of the request
+  MintFsInfo info = 3;
 }
 
 // Success message associated with CreateMintFsTxResp
@@ -68,9 +68,9 @@ message CreateGcFsTxResp {
     Error error = 1;
     // Successfull Fact Statement garbage collection message
     GcFsSuccess success = 2;
-    // Request processing information
-    GcFsInfo info = 3;
   }
+  // Request processing information
+  GcFsInfo info = 3;
 }
 
 // Success message associated with the CreateGcFsTxResp