Skip to content
This repository was archived by the owner on Mar 10, 2022. It is now read-only.

Commit b8c8f0c

Browse files
author
Andrew Lloyd
authored
Merge pull request #28 from nodes-ios/develop
Swift 4 update
2 parents 71698b3 + 5234fae commit b8c8f0c

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

.travis.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
language: objective-c
2-
osx_image: xcode8.1
2+
osx_image: xcode9.1
33
branches:
44
only:
55
- master
@@ -9,9 +9,9 @@ env:
99
global:
1010
- PROJECT_NAME="KeyboardHelper.xcodeproj"
1111
- IOS_FRAMEWORK_SCHEME="KeyboardHelper"
12-
- IOS_SDK=iphonesimulator10.1
12+
- IOS_SDK=iphonesimulator11.1
1313
matrix:
14-
- DESTINATION="OS=10.1,name=iPhone 6S Plus" SCHEME="$IOS_FRAMEWORK_SCHEME" SDK="$IOS_SDK" RUN_TESTS="YES"
14+
- DESTINATION="OS=11.1,name=iPhone 6S Plus" SCHEME="$IOS_FRAMEWORK_SCHEME" SDK="$IOS_SDK" RUN_TESTS="YES"
1515

1616
script:
1717
- set -o pipefail

KeyboardHelper.xcodeproj/project.pbxproj

+10-6
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,11 @@
189189
TargetAttributes = {
190190
275BCA761C57C9F800FF3647 = {
191191
CreatedOnToolsVersion = 7.2;
192-
LastSwiftMigration = 0800;
192+
LastSwiftMigration = 0900;
193193
};
194194
275BCA801C57C9F800FF3647 = {
195195
CreatedOnToolsVersion = 7.2;
196-
LastSwiftMigration = 0800;
196+
LastSwiftMigration = 0900;
197197
};
198198
};
199199
};
@@ -368,7 +368,8 @@
368368
SKIP_INSTALL = YES;
369369
SWIFT_OBJC_INTERFACE_HEADER_NAME = "$(SWIFT_MODULE_NAME)-Swift.h";
370370
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
371-
SWIFT_VERSION = 3.0;
371+
SWIFT_SWIFT3_OBJC_INFERENCE = On;
372+
SWIFT_VERSION = 4.0;
372373
};
373374
name = Debug;
374375
};
@@ -387,7 +388,8 @@
387388
SKIP_INSTALL = YES;
388389
SWIFT_OBJC_INTERFACE_HEADER_NAME = "$(SWIFT_MODULE_NAME)-Swift.h";
389390
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
390-
SWIFT_VERSION = 3.0;
391+
SWIFT_SWIFT3_OBJC_INFERENCE = On;
392+
SWIFT_VERSION = 4.0;
391393
};
392394
name = Release;
393395
};
@@ -398,7 +400,8 @@
398400
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
399401
PRODUCT_BUNDLE_IDENTIFIER = com.nodes.KeyboardHelperTests;
400402
PRODUCT_NAME = "$(TARGET_NAME)";
401-
SWIFT_VERSION = 3.0;
403+
SWIFT_SWIFT3_OBJC_INFERENCE = On;
404+
SWIFT_VERSION = 4.0;
402405
};
403406
name = Debug;
404407
};
@@ -410,7 +413,8 @@
410413
PRODUCT_BUNDLE_IDENTIFIER = com.nodes.KeyboardHelperTests;
411414
PRODUCT_NAME = "$(TARGET_NAME)";
412415
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
413-
SWIFT_VERSION = 3.0;
416+
SWIFT_SWIFT3_OBJC_INFERENCE = On;
417+
SWIFT_VERSION = 4.0;
414418
};
415419
name = Release;
416420
};

KeyboardHelper/Classes/KeyboardHelper.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ public class KeyboardHelper {
5555
delegate = nil
5656
}
5757

58-
dynamic private func keyboardWillAppear(_ note: Notification) {
58+
@objc dynamic private func keyboardWillAppear(_ note: Notification) {
5959
let info = KeyboardAppearanceInfo(notification: note)
6060
self.delegate?.keyboardWillAppear(info)
6161
}
6262

63-
dynamic private func keyboardWillDisappear(_ note: Notification) {
63+
@objc dynamic private func keyboardWillDisappear(_ note: Notification) {
6464
let info = KeyboardAppearanceInfo(notification: note)
6565
self.delegate?.keyboardWillDisappear(info)
6666
}

0 commit comments

Comments
 (0)