avoid idle timeout loop

Author: jakewski

src/recorder/session-recording.js

@@ -187,6 +187,7 @@ SessionRecording.prototype.startRecording = function (shouldStopBatcher) {
         this.idleTimeoutId = setTimeout(this._onIdleTimeout, idleTimeoutMs);
         this.idleExpires = new Date().getTime() + idleTimeoutMs;
     }.bind(this);
+    resetIdleTimeout();
 
     var blockSelector = this.getConfig('record_block_selector');
     if (blockSelector === '' || blockSelector === null) {
@@ -196,7 +197,7 @@ SessionRecording.prototype.startRecording = function (shouldStopBatcher) {
     try {
         this._stopRecording = this._rrwebRecord({
             'emit': function (ev) {
-                if (this.idleExpires < ev.timestamp) {
+                if (this.idleExpires && this.idleExpires < ev.timestamp) {
                     this._onIdleTimeout();
                     return;
                 }
@@ -236,8 +237,6 @@ SessionRecording.prototype.startRecording = function (shouldStopBatcher) {
         return;
     }
 
-    resetIdleTimeout();
-
     var maxTimeoutMs = this.maxExpires - new Date().getTime();
     this.maxTimeoutId = setTimeout(this._onMaxLengthReached.bind(this), maxTimeoutMs);
 };

tests/unit/session-recording.js

@@ -101,7 +101,6 @@ describe(`SessionRecording`, function() {
 
     expect(flushSpy.calledOnce).to.be.false;
     expect(sessionRecording.batcher.stopped).to.be.true;
-    expect(sessionRecording.idleTimeoutId).to.be.null;
     expect(sessionRecording.maxTimeoutId).to.be.null;
   });