-
Notifications
You must be signed in to change notification settings - Fork 0
Description
The strip string node should follow the python3 strip functionality. Currently, it strips whitespace if nothing is provided to the 'Characters' input. If a character is provided to the 'Characters' input, then it properly strips that character from the front and back of the provided String.
The bug is that the node only uses the first character in the 'Characters' input for the strip operation even if a full string is provided. It should instead either follow the 'strip all matching characters' behavior of the python3 libs or should remove matching substrings from the front/back of the string.
The python description of split:
https://docs.python.org/3/library/stdtypes.html#str.strip
The relevant node in GraphEx:
https://github.com/mitre/GraphEx/blob/main/graphex/nodes/strings.py#L93