-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub workflow to build and publish Docker image on the GitHub container registry #670
base: develop
Are you sure you want to change the base?
Add GitHub workflow to build and publish Docker image on the GitHub container registry #670
Conversation
Hey @johnwunder @seansica, let me know if there is anything i can help with. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for the contribution. Please refactor these changes to align more closely with our other Docker workflows; namely the ATT&CK Workbench REST API publish.yml workflow.
There are some notable differences in biz logic:
- Should run push to branches
master
,develop
, as well as push git tagsv*.*.*
(semver) as opposed to any wildcard value (*
) - Should only generate Docker metadata tags/values for the following:
latest
for branchmaster
develop
for branchdevelop
vX.Y.Z
for git tag event (git tag must follow semver format)
- Should not operate on PRs (set
push: ${{ github.event_name != 'pull_request' }}
)
Our current Docker workflow is not tethered to GitHub Releases, so the workflow should be decoupled from create-release.yml
and moved to a new workflow file.
|
Hey @seansica, thanks for your feedback. I simply copied the workflow from the repo you've mentioned. Let me know if this resolves your change requests. Furthermore, do you know when the next release is planned so I can you a tagged image? Thanks in advance. |
Hey,
as mentioned in the title, this PR adds the functionality to automatically create a Docker image when a new release is created. This image is then published to the GitHub container registry of this repository. I think it's a more easy way to use and install the navigator. Let me know what you think.
For implementation i sticked to the official documentation from GitHub.
Here is an example pipeline i run in my fork and you can find the published image here.