Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow to build and publish Docker image on the GitHub container registry #670

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nikstuckenbrock
Copy link

Hey,

as mentioned in the title, this PR adds the functionality to automatically create a Docker image when a new release is created. This image is then published to the GitHub container registry of this repository. I think it's a more easy way to use and install the navigator. Let me know what you think.

For implementation i sticked to the official documentation from GitHub.

Here is an example pipeline i run in my fork and you can find the published image here.

@nikstuckenbrock nikstuckenbrock changed the base branch from master to develop February 5, 2025 09:04
@nikstuckenbrock
Copy link
Author

Hey @johnwunder @seansica,

let me know if there is anything i can help with. Thanks in advance!

Copy link
Contributor

@seansica seansica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for the contribution. Please refactor these changes to align more closely with our other Docker workflows; namely the ATT&CK Workbench REST API publish.yml workflow.

There are some notable differences in biz logic:

  • Should run push to branches master, develop, as well as push git tags v*.*.* (semver) as opposed to any wildcard value (*)
  • Should only generate Docker metadata tags/values for the following:
    • latest for branch master
    • develop for branch develop
    • vX.Y.Z for git tag event (git tag must follow semver format)
  • Should not operate on PRs (set push: ${{ github.event_name != 'pull_request' }})

Our current Docker workflow is not tethered to GitHub Releases, so the workflow should be decoupled from create-release.yml and moved to a new workflow file.

@nikstuckenbrock
Copy link
Author

Hey @seansica,

thanks for your feedback. I simply copied the workflow from the repo you've mentioned. Let me know if this resolves your change requests. Furthermore, do you know when the next release is planned so I can you a tagged image? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants