Ensure default favorites list gets created for new scim users (#2364)

* calling plugin method for new users

* Revert "calling plugin method for new users"

This reverts commit d8c678d.

* adding auth plugin call for scim users

* making sure scim adapter calls plugin method for user creation

* removing duplicate favorites plugin from defaults

* switching to using authentication method

Author: shanbady

main/settings_pluggy.py

@@ -2,7 +2,7 @@
 
 MITOL_AUTHENTICATION_PLUGINS = get_string(
     "MITOL_AUTHENTICATION_PLUGINS",
-    "learning_resources.plugins.FavoritesListPlugin,profiles.plugins.CreateProfilePlugin,learning_resources.plugins.FavoritesListPlugin",
+    "learning_resources.plugins.FavoritesListPlugin,profiles.plugins.CreateProfilePlugin",
 )
 MITOL_LEARNING_RESOURCES_PLUGINS = get_string(
     "MITOL_LEARNING_RESOURCES_PLUGINS",

users/adapters.py

@@ -1,5 +1,6 @@
 from mitol.scim.adapters import UserAdapter
 
+from authentication.api import user_created_actions
 from profiles.models import Profile
 
 
@@ -45,6 +46,7 @@ def _save_related(self):
         """
         self.obj.profile.user = self.obj
         self.obj.profile.save()
+        user_created_actions(user=self.obj, details=self.to_dict(), is_new=True)
 
     def _handle_replace_nested_path(self, nested_path, nested_value):
         """Per-path replacement handling"""

users/adapters_test.py

@@ -0,0 +1,31 @@
+import pytest
+from django.test import RequestFactory
+
+from main.factories import UserFactory
+from users.adapters import LearnUserAdapter
+
+
+@pytest.mark.django_db
+def test_save_related_creates_profile_and_favorites_if_missing(mocker, settings):
+    """
+    Test that saving a LearnUserAdapter creates a profile and default favorites list
+    """
+    settings.MITOL_AUTHENTICATION_PLUGINS = "learning_resources.plugins.FavoritesListPlugin,profiles.plugins.CreateProfilePlugin"
+    user = UserFactory()
+
+    scimUser = LearnUserAdapter(user)
+    scimUser.request = RequestFactory()
+    scimUser.obj.request = RequestFactory()
+    scimUser.from_dict(
+        {
+            "userName": "test",
+            "fullName": {"name": "test"},
+            "externalId": 123,
+            "profile": {},
+        }
+    )
+    scimUser.save()
+    user.refresh_from_db()
+    assert user.user_lists.count() == 1
+    # Profile should be linked to user and saved
+    assert user.profile.user == user