Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use op_id in code unless it is intentionally ambiguous #152

Open
mdr223 opened this issue Feb 26, 2025 · 0 comments
Open

Don't use op_id in code unless it is intentionally ambiguous #152

mdr223 opened this issue Feb 26, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mdr223
Copy link
Collaborator

mdr223 commented Feb 26, 2025

There are a number of places in the code where we use op_id to refer to a physical_op_id or a logical_op_id; we should rename all such instances (where the op_id is not intentionally ambiguous) to explicitly be phsyical_op_id or logical_op_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant