Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GenerationStats to Handle Summation of embed_stats and generation_stats in RAGConvert.convert() #131

Open
mdr223 opened this issue Feb 18, 2025 · 0 comments
Labels
invalid This doesn't seem right

Comments

@mdr223
Copy link
Collaborator

mdr223 commented Feb 18, 2025

Summing the embed_stats and generation_stats leads to correct calculations of operator-record, operator, plan, and execution stats.

However, if one were to analyze our stats in post-processing -- they would have no way of parsing which e.g. total_input_tokens came from the embedding step and which came from the generation step.

@mdr223 mdr223 added the invalid This doesn't seem right label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant