Skip to content

Support all the methods from the API #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davesnx opened this issue Jan 12, 2017 · 8 comments
Closed

Support all the methods from the API #66

davesnx opened this issue Jan 12, 2017 · 8 comments

Comments

@davesnx
Copy link
Contributor

davesnx commented Jan 12, 2017

Hey @mishk0,

Seems that this module doesn't support all the endpoints available on the API api.slack.com/methods.

What about have some methods defined by a configuration file (often a yaml) that defines all the methods from the API with the parameters and have other "custom" methods implemented directly in JavaScript. Like getGroupById, getChannelById, etc...

We could apart of support all the methods from the API, explain how this slack-api-client add extra value of the raw slack API.

Thanks :D

@mishk0
Copy link
Owner

mishk0 commented Jan 12, 2017

Yes. Initially, that module was designed for "sending message" purpose. I was convinced, that adding a new simple wrapper for every API call is redundant. Could you show a code of a method that defined by a configuration file, in order to avoid misunderstandings :)

@davesnx
Copy link
Contributor Author

davesnx commented Jan 12, 2017

yml file is a subset of JSON, it's just define a json file like that:

{
  "methods": [
    {
      "endpoint": "channels:history",
      "type": "GET",
      "parameters": {
          "name": "channel"
      }
    }
  ]
}

and the parse it and assign to the get/post private method from the class.

Sounds good?

@davesnx
Copy link
Contributor Author

davesnx commented Jan 12, 2017

and aswell, we can have the documentation dynamic, just adding jsDoc it will output that on the README. Like swagger.

@mishk0
Copy link
Owner

mishk0 commented Jan 13, 2017

Yes, sounds good. Anyway, I don't see a huge advantage over js functions. But... could you do PR? :)

@TheGrandmother
Copy link

This feature would be really nice to have but i also don't really see why we shouldn't just use JS functions.

@hydeenoble
Copy link

hydeenoble commented Nov 25, 2018

Are we still supporting all methods from the Slack API?

@davesnx davesnx closed this as completed Nov 26, 2018
@davesnx
Copy link
Contributor Author

davesnx commented Nov 26, 2018

I'm closing this since there's no activity related to that.
I particularly implemented myself the Slack interface with my App

@hydeenoble
Copy link

Hello @davesnx, I currently have a PR (#115) for the "files.upload" method for slack API which I need in an App in am currently working on.

I would be glad if activities related to all other methods in the slack API begins all over again and I am more than ready to help.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants