Skip to content

Commit c027c18

Browse files
committed
Force fontconfig-parser version to v0.5.7
1 parent 4f1572f commit c027c18

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

Cargo.lock

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,3 +286,14 @@ opt-level = 2
286286
[features]
287287
trezor = []
288288
default = ["trezor"]
289+
290+
[patch.crates-io]
291+
# Using fontconfig-parser v0.5.8 completely breaks UI in node-gui on Linux - most of the text disappears and the few
292+
# characters that remain have broken spacing, so we force the usage of v0.5.7 via "patch".
293+
# Note: the commit is called "Bump version" and it's where the version was bumped to "0.5.7"; it is the last "good"
294+
# revision. The following ("bad") revision belongs to the PR https://github.com/Riey/fontconfig-parser/pull/11 which
295+
# claims to fix certain issues. So it's possible that fontconfig-parser v0.5.8 is actually good, but a dependent crate
296+
# uses it incorrectly (so v0.5.7 works only because several bugs cancel each other out). The current dependency chain
297+
# is fontconfig-parser <- fontdb <- cosmic-text <- various "iced" crates.
298+
# TODO: investigate this further.
299+
fontconfig-parser = { git = "https://github.com/Riey/fontconfig-parser", rev = "f7d13a779e6ee282ce75acbc00a1270c0350e0c2" }

0 commit comments

Comments
 (0)