Add new tests proving that 1) signatures on FillOrder inputs are not enforced by chainstate; 2) submitting 2 txs with identical FillOrder inputs is handled gracefully by mempool

Author: ImplOfAnImpl

chainstate/test-framework/src/framework.rs

@@ -49,6 +49,7 @@ use common::{
 use crypto::{key::PrivateKey, vrf::VRFPrivateKey};
 use randomness::{CryptoRng, Rng};
 use utils::atomics::SeqCstAtomicU64;
+use utxo::Utxo;
 
 /// The `Chainstate` wrapper that simplifies operations and checks in the tests.
 #[must_use]
@@ -590,11 +591,12 @@ impl TestFramework {
         self.best_block_height().next_height()
     }
 
+    pub fn utxo(&self, outpoint: &UtxoOutPoint) -> Utxo {
+        self.chainstate.utxo(outpoint).unwrap().unwrap()
+    }
+
     pub fn coin_amount_from_utxo(&self, outpoint: &UtxoOutPoint) -> Amount {
-        get_output_value(self.chainstate.utxo(outpoint).unwrap().unwrap().output())
-            .unwrap()
-            .coin_amount()
-            .unwrap()
+        get_output_value(self.utxo(outpoint).output()).unwrap().coin_amount().unwrap()
     }
 }
 

chainstate/test-suite/src/tests/helpers/mod.rs

@@ -24,12 +24,13 @@ use common::{
         signature::inputsig::InputWitness,
         timelock::OutputTimeLock,
         tokens::{TokenId, TokenIssuance},
-        AccountCommand, AccountNonce, AccountType, Block, Destination, GenBlock, Transaction,
-        TxInput, TxOutput, UtxoOutPoint,
+        AccountCommand, AccountNonce, AccountType, Block, Destination, GenBlock, OrderId,
+        OrdersVersion, Transaction, TxInput, TxOutput, UtxoOutPoint,
     },
     primitives::{Amount, BlockDistance, BlockHeight, Id, Idable},
 };
 use crypto::key::{KeyKind, PrivateKey};
+use orders_accounting::OrdersAccountingDB;
 use randomness::{CryptoRng, Rng};
 
 pub mod block_creation_helpers;
@@ -185,3 +186,21 @@ pub fn mint_tokens_in_block(
 
     (block_id, tx_id)
 }
+
+/// Given the fill amount in the "ask" currency, return the filled amount in the "give" currency.
+pub fn calculate_fill_order(
+    tf: &TestFramework,
+    order_id: &OrderId,
+    fill_amount_in_ask_currency: Amount,
+    orders_version: OrdersVersion,
+) -> Amount {
+    let db_tx = tf.storage.transaction_ro().unwrap();
+    let orders_db = OrdersAccountingDB::new(&db_tx);
+    orders_accounting::calculate_fill_order(
+        &orders_db,
+        *order_id,
+        fill_amount_in_ask_currency,
+        orders_version,
+    )
+    .unwrap()
+}