Golf a bit internal/ui/static/js/modal_handler.js

- Re-use an existing function instead of copy-pasting its code
- Use optional chaining instead of a condition
- Use the modern `.at` method instead of `[focusableElements.length - 1], as
  it's supported on all browsers since 2016: https://caniuse.com/mdn-javascript_builtins_string_at

Author: jvoisin

Diff for: .github/workflows/linters.yml

@@ -17,7 +17,7 @@ jobs:
       run: |
         sudo npm install -g [email protected] [email protected]
     - name: Run jshint
-      run: jshint internal/ui/static/js/*.js
+      run: jshint --config .jshintrc internal/ui/static/js/*.js
     - name: Run ESLint
       run: eslint internal/ui/static/js/*.js
 

Diff for: internal/ui/static/js/modal_handler.js

@@ -1,20 +1,15 @@
 class ModalHandler {
     static exists() {
-        return document.getElementById("modal-container") !== null;
+        return getModalContainer() !== null;
     }
 
     static getModalContainer() {
         return document.getElementById("modal-container");
     }
 
     static getFocusableElements() {
-        const container = this.getModalContainer();
-
-        if (container === null) {
-            return null;
-        }
-
-        return container.querySelectorAll('button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])');
+        const container = this.getModalContainer()
+        return container?.querySelectorAll('button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])');
     }
 
     static setupFocusTrap() {
@@ -25,7 +20,7 @@ class ModalHandler {
         }
 
         const firstFocusableElement = focusableElements[0];
-        const lastFocusableElement = focusableElements[focusableElements.length - 1];
+        const lastFocusableElement = focusableElements.at(-1);
 
         this.getModalContainer().onkeydown = (e) => {
             if (e.key !== 'Tab') {