Skip to content

Commit 0c2bc34

Browse files
authored
Update proto to v2.5.8 (#1354)
Signed-off-by: yhmo <[email protected]>
1 parent 78ba573 commit 0c2bc34

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ services:
7777

7878
standaloneslave:
7979
container_name: milvus-javasdk-test-slave-standalone
80-
image: milvusdb/milvus:v2.5.4
80+
image: milvusdb/milvus:v2.5.7
8181
command: ["milvus", "run", "standalone"]
8282
environment:
8383
ETCD_ENDPOINTS: etcdslave:2379

sdk-core/src/test/java/io/milvus/client/MilvusClientDockerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class MilvusClientDockerTest {
7878
private static final TestUtils utils = new TestUtils(DIMENSION);
7979

8080
@Container
81-
private static final MilvusContainer milvus = new MilvusContainer("milvusdb/milvus:v2.5.4");
81+
private static final MilvusContainer milvus = new MilvusContainer("milvusdb/milvus:v2.5.7");
8282

8383
@BeforeAll
8484
public static void setUp() {

sdk-core/src/test/java/io/milvus/v2/client/MilvusClientV2DockerTest.java

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class MilvusClientV2DockerTest {
8080
private static final TestUtils utils = new TestUtils(DIMENSION);
8181

8282
@Container
83-
private static final MilvusContainer milvus = new MilvusContainer("milvusdb/milvus:v2.5.4");
83+
private static final MilvusContainer milvus = new MilvusContainer("milvusdb/milvus:v2.5.7");
8484

8585
@BeforeAll
8686
public static void setUp() {
@@ -1008,19 +1008,16 @@ void testAlias() {
10081008
.build());
10091009
Assertions.assertEquals("desc_B", descResp.getDescription());
10101010

1011-
client.dropCollection(DropCollectionReq.builder()
1012-
.collectionName("BBB")
1013-
.build());
1014-
1015-
Assertions.assertThrows(MilvusClientException.class, ()->client.describeCollection(DescribeCollectionReq.builder()
1016-
.collectionName("CCC")
1017-
.build()));
1018-
1011+
// must drop or alter alias before dropping the collection
10191012
client.alterAlias(AlterAliasReq.builder()
10201013
.collectionName("AAA")
10211014
.alias("CCC")
10221015
.build());
10231016

1017+
client.dropCollection(DropCollectionReq.builder()
1018+
.collectionName("BBB")
1019+
.build());
1020+
10241021
descResp = client.describeCollection(DescribeCollectionReq.builder()
10251022
.collectionName("CCC")
10261023
.build());

0 commit comments

Comments
 (0)