Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dataset metadata output to CLI #18

Open
mikulatomas opened this issue Apr 2, 2020 · 2 comments
Open

Add Dataset metadata output to CLI #18

mikulatomas opened this issue Apr 2, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
0.1.3

Comments

@mikulatomas
Copy link
Owner

mikulatomas commented Apr 2, 2020 •
edited
Loading

Allow something like this:

convertme -i dataset.csv -if=csv -o dataset.fimi -of=fimi --metadata metadata.json

Metadata object can be outputed from Dataset object after dataset is created with Reader.
@mikulatomas mikulatomas added this to the Next release milestone Apr 2, 2020
@mikulatomas mikulatomas added the enhancement New feature or request label Apr 2, 2020
@tomasurbanec
Copy link
Collaborator

This means change in reader interface (and therefore in all readers), doesn't it?

@tomasurbanec tomasurbanec mentioned this issue Apr 6, 2020
Closed
@mikulatomas
Copy link
Owner Author

It should be enough to access metadata from Dataset object (in CLI) during conversion.

convertme/convertme/cli.py

Line 95 in a204e94

writer.write(reader.read(input_), output_)

@mikulatomas mikulatomas modified the milestones: 0.1.2, 0.1.3 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.3
Development

No branches or pull requests
2 participants
@mikulatomas @tomasurbanec