Improve Vector search for char* argument

Author: mikee47

src/String.cpp

@@ -23,7 +23,7 @@
 
 namespace FSTR
 {
-bool String::equals(const char* cstr, size_t clen) const
+bool String::equals(const char* cstr, size_t clen, bool ignoreCase) const
 {
 	// Unlikely we'd want an empty flash string, but check anyway
 	if(cstr == nullptr) {
@@ -38,6 +38,9 @@ bool String::equals(const char* cstr, size_t clen) const
 		return false;
 	}
 	LOAD_FSTR(buf, *this);
+	if(ignoreCase) {
+		return memicmp(buf, cstr, len) == 0;
+	}
 	return memcmp(buf, cstr, len) == 0;
 }
 

src/include/FlashString/String.hpp

@@ -197,7 +197,12 @@ class String : public Object<String, char>
 	 * @retval bool true if strings are identical
 	 * @note loads string into a stack buffer for the comparison, no heap required
 	 */
-	bool equals(const char* cstr, size_t len = 0) const;
+	bool equals(const char* cstr, size_t len = 0, bool ignoreCase = false) const;
+
+	bool equalsIgnoreCase(const char* cstr, size_t len = 0) const
+	{
+		return equals(cstr, len, true);
+	}
 
 	/** @brief Check for equality with another String
 	 *  @param str

src/include/FlashString/Vector.hpp

@@ -113,6 +113,26 @@ template <class ObjectType> class Vector : public Object<Vector<ObjectType>, con
 
 	using Object<Vector<ObjectType>, const ObjectType*>::indexOf;
 
+	template <typename T = ObjectType>
+	typename std::enable_if<std::is_same<T, String>::value, int>::type indexOf(const char* value,
+																			   bool ignoreCase = true) const
+	{
+		if(!ignoreCase) {
+			return Object<Vector<String>, const String*>::indexOf(value);
+		}
+
+		auto dataptr = this->data();
+		auto len = this->length();
+		auto clen = strlen(value);
+		for(unsigned i = 0; i < len; ++i) {
+			if(unsafeValueAt(dataptr, i).equalsIgnoreCase(value, clen)) {
+				return i;
+			}
+		}
+
+		return -1;
+	}
+
 	template <typename ValueType, typename T = ObjectType>
 	typename std::enable_if<std::is_same<T, String>::value, int>::type indexOf(const ValueType& value,
 																			   bool ignoreCase = true) const