Skip to content

Commit 21370fc

Browse files
authoredDec 30, 2021
fix: support uppercase level and migreate code (#1)
1 parent 6713f4f commit 21370fc

File tree

6 files changed

+38
-102
lines changed

6 files changed

+38
-102
lines changed
 

‎.github/workflows/benchmark.yml

-40
This file was deleted.

‎.github/workflows/nodejs.yml

+18-52
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,7 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [12.x, 14.x, 16.x]
13-
14-
services:
15-
redis:
16-
image: redis
17-
options: >-
18-
--health-cmd "redis-cli ping"
19-
--health-interval 10s
20-
--health-timeout 5s
21-
--health-retries 5
22-
ports:
23-
- 6379:6379
24-
rabbitmq:
25-
image: rabbitmq:latest
26-
ports:
27-
- 5672/tcp
28-
options: --health-cmd "rabbitmqctl node_health_check" --health-interval 10s --health-timeout 5s --health-retries 5
12+
node-version: [10.x, 12.x, 14.x, 16.x]
2913

3014
steps:
3115
- name: Git checkout
@@ -36,45 +20,27 @@ jobs:
3620
with:
3721
node-version: ${{ matrix.node-version }}
3822

39-
- name: Start MongoDB
40-
uses: supercharge/mongodb-github-action@1.6.0
41-
with:
42-
mongodb-version: 4.2
43-
4423
- run: npm install && npm install codecov
45-
- run: npm run bootstrap
4624
- run: npm run build --if-present
4725
- run: npm run lint
4826
- run: npm run cov
49-
env:
50-
RABBITMQ_URL: amqp://localhost:${{ job.services.rabbitmq.ports[5672] }}
51-
ALI_SDK_OSS_REGION: ${{ secrets.ALI_SDK_OSS_REGION }}
52-
ALI_SDK_OSS_ENDPOINT: ${{ secrets.ALI_SDK_OSS_ENDPOINT }}
53-
ALI_SDK_OSS_ID: ${{ secrets.ALI_SDK_OSS_ID }}
54-
ALI_SDK_OSS_SECRET: ${{ secrets.ALI_SDK_OSS_SECRET }}
55-
ALI_SDK_OSS_BUCKET: ${{ secrets.ALI_SDK_OSS_BUCKET }}
56-
ALI_SDK_STS_ID: ${{ secrets.ALI_SDK_STS_ID }}
57-
ALI_SDK_STS_SECRET: ${{ secrets.ALI_SDK_STS_SECRET }}
58-
ALI_SDK_STS_BUCKET: ${{ secrets.ALI_SDK_STS_BUCKET }}
59-
ALI_SDK_STS_ROLE: ${{ secrets.ALI_SDK_STS_ROLE }}
6027
- name: Upload coverage to Codecov
6128
uses: codecov/codecov-action@v1
6229

63-
#
64-
# build-windows:
65-
# runs-on: windows-latest
66-
#
67-
# strategy:
68-
# matrix:
69-
# node-version: [12.x, 14.x]
70-
#
71-
# steps:
72-
# - uses: actions/checkout@v2
73-
# - name: Use Node.js ${{ matrix.node-version }}
74-
# uses: actions/setup-node@v1
75-
# with:
76-
# node-version: ${{ matrix.node-version }}
77-
# - run: npm install
78-
# - run: npm run bootstrap
79-
# - run: npm run build --if-present
80-
# - run: npm run cov
30+
31+
# build-windows:
32+
# runs-on: windows-latest
33+
34+
# strategy:
35+
# matrix:
36+
# node-version: [12.x, 14.x]
37+
38+
# steps:
39+
# - uses: actions/checkout@v2
40+
# - name: Use Node.js ${{ matrix.node-version }}
41+
# uses: actions/setup-node@v1
42+
# with:
43+
# node-version: ${{ matrix.node-version }}
44+
# - run: npm install
45+
# - run: npm run build --if-present
46+
# - run: npm run cov

‎.prettierrc.js

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
module.exports = {
2+
...require('mwts/.prettierrc.json')
3+
}

‎package.json

+7-3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"@types/jest": "^27.0.0",
1616
"@types/node": "16.11.17",
1717
"colors": "^1.4.0",
18+
"cross-env": "^6.0.3",
1819
"egg-logger": "^2.7.1",
1920
"fs-extra": "^8.1.0",
2021
"jest": "27.4.5",
@@ -28,16 +29,19 @@
2829
},
2930
"files": [
3031
"dist/**/*.js",
31-
"dist/**/*.d.ts"
32+
"dist/**/*.d.ts",
33+
"dist/**/*.js.map"
3234
],
3335
"keywords": [
3436
"midway",
3537
"logger"
3638
],
3739
"scripts": {
3840
"build": "rm -rf dist && tsc",
39-
"test": "jest",
40-
"cov": "jest --coverage --forceExit"
41+
"test": "cross-env node --require=ts-node/register ./node_modules/.bin/jest",
42+
"cov": "cross-env node --require=ts-node/register ./node_modules/.bin/jest --coverage --forceExit",
43+
"lint": "mwts check",
44+
"lint:fix": "mwts fix"
4145
},
4246
"repository": {
4347
"type": "git",

‎src/interface.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export interface IMidwayLogger extends ILogger {
3838
close(): any;
3939
}
4040

41-
export type LoggerLevel = 'all' | 'silly' | 'debug' | 'info' | 'warn' | 'error' | 'none';
41+
export type LoggerLevel = 'all' | 'silly' | 'debug' | 'info' | 'warn' | 'error' | 'none' | 'ALL' | 'DEBUG' | 'INFO' | 'WARN' | 'ERROR' | 'NONE';
4242

4343
export interface LoggerOptions {
4444
format?: logform.Format;

‎src/logger.ts

+9-6
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export class MidwayBaseLogger extends EmptyLogger implements IMidwayLogger {
108108
);
109109

110110
this.consoleTransport = new transports.Console({
111-
level: options.consoleLevel || options.level || 'silly',
111+
level: (options.consoleLevel || options.level || 'silly').toLowerCase(),
112112
format: format.combine(
113113
process.env.MIDWAY_LOGGER_DISABLE_COLORS !== 'true'
114114
? format.colorize({
@@ -193,8 +193,11 @@ export class MidwayBaseLogger extends EmptyLogger implements IMidwayLogger {
193193
dirname: this.loggerOptions.dir,
194194
filename: this.loggerOptions.fileLogName,
195195
datePattern: this.loggerOptions.fileDatePattern || 'YYYY-MM-DD',
196-
level:
197-
this.loggerOptions.fileLevel || this.loggerOptions.level || 'silly',
196+
level: (
197+
this.loggerOptions.fileLevel ||
198+
this.loggerOptions.level ||
199+
'silly'
200+
).toLowerCase(),
198201
createSymlink: this.loggerOptions.disableFileSymlink !== true,
199202
symlinkName: this.loggerOptions.fileLogName,
200203
maxSize: this.loggerOptions.fileMaxSize || '200m',
@@ -249,17 +252,17 @@ export class MidwayBaseLogger extends EmptyLogger implements IMidwayLogger {
249252
}
250253

251254
updateLevel(level: LoggerLevel): void {
252-
this.level = level;
255+
this.level = level.toLowerCase();
253256
this.consoleTransport.level = level;
254257
this.fileTransport.level = level;
255258
}
256259

257260
updateFileLevel(level: LoggerLevel): void {
258-
this.fileTransport.level = level;
261+
this.fileTransport.level = level.toLowerCase();
259262
}
260263

261264
updateConsoleLevel(level: LoggerLevel): void {
262-
this.consoleTransport.level = level;
265+
this.consoleTransport.level = level.toLowerCase();
263266
}
264267

265268
updateDefaultLabel(defaultLabel: string): void {

0 commit comments

Comments
 (0)
Please sign in to comment.