File tree Expand file tree Collapse file tree 1 file changed +11
-1
lines changed
Expand file tree Collapse file tree 1 file changed +11
-1
lines changed Original file line number Diff line number Diff line change 11
22### Graph JS Deliverables:
33
4- Note: Package names yet to be decided
4+ Note: Package names yet to be decided. The names are just examples and ` service ` and ` core ` prefix in the package names are for clarity purposes.
55
661 . ` microsoftgraph/microsoft-graph-javascript-service ` :
77
@@ -25,6 +25,15 @@ Note: Package names yet to be decided
2525
2626As mentioned in PR: #558
2727
28+ Also, tasks constructors such as ` PageIterator ` and ` LargeFileUpload ` tasks should accept both ` GraphServiceClient ` and ` GraphCoreClient `
29+
30+ ```
31+ // both should work
32+ const pageIterator = PageIterator(GraphServiceClient, options);
33+ or
34+ const pageIterator = PageIterator(GraphCoreClient, options);
35+ ```
36+
2837Goals:
2938
3039- A Graph JS SDK user should not be required to create separate client instances for Graph Service library or the Graph Core library.
@@ -45,6 +54,7 @@ class GraphServiceClient extends GraphCoreClient {
4554 super.api();
4655 }
4756}
57+
4858```
4959
5060- To acheive the above design we will need to customize the auto-generated ` GraphServiceClient ` .
You can’t perform that action at this time.
0 commit comments