Add argument for ignoring warnings (#3572)

Author: Trenly

.github/actions/spelling/allow.txt

@@ -355,6 +355,7 @@ normalizedpackagenameandpublisher
 NOTHROW
 NOTIMPL
 NOTNULL
+nowarn
 npos
 NTFS
 NTSTATUS

src/AppInstallerCLICore/Argument.cpp

@@ -119,6 +119,8 @@ namespace AppInstaller::CLI
         //Validate Command
         case Execution::Args::Type::ValidateManifest:
             return { type, "manifest"_liv };
+        case Execution::Args::Type::IgnoreWarnings:
+            return { type, "ignore-warnings"_liv, "nowarn"_liv};
 
         // Complete Command
         case Execution::Args::Type::Word:
@@ -313,6 +315,8 @@ namespace AppInstaller::CLI
             return Argument{ type, Resource::String::SourceTypeArgumentDescription, ArgumentType::Positional };
         case Args::Type::ValidateManifest:
             return Argument{ type, Resource::String::ValidateManifestArgumentDescription, ArgumentType::Positional, true };
+        case Args::Type::IgnoreWarnings:
+            return Argument{ type, Resource::String::IgnoreWarningsArgumentDescription, ArgumentType::Flag, Argument::Visibility::Help };
         case Args::Type::NoVT:
             return Argument{ type, Resource::String::NoVTArgumentDescription, ArgumentType::Flag, Argument::Visibility::Hidden };
         case Args::Type::RainbowStyle:

src/AppInstallerCLICore/Commands/ValidateCommand.cpp

@@ -16,6 +16,7 @@ namespace AppInstaller::CLI
     {
         return {
             Argument::ForType(Execution::Args::Type::ValidateManifest),
+            Argument::ForType(Execution::Args::Type::IgnoreWarnings),
         };
     }
 
@@ -46,7 +47,7 @@ namespace AppInstaller::CLI
             {
                 ManifestValidateOption validateOption;
                 validateOption.FullValidation = true;
-                validateOption.ThrowOnWarning = true;
+                validateOption.ThrowOnWarning = !(context.Args.Contains(Execution::Args::Type::IgnoreWarnings));
                 auto manifest = YamlParser::CreateFromPath(inputFile, validateOption);
 
                 context.Add<Execution::Data::Manifest>(manifest);

src/AppInstallerCLICore/ExecutionArgs.h

@@ -66,6 +66,7 @@ namespace AppInstaller::CLI::Execution
 
             //Validate Command
             ValidateManifest,
+            IgnoreWarnings,
 
             // Complete Command
             Word,

src/AppInstallerCLICore/Resources.h

@@ -207,6 +207,7 @@ namespace AppInstaller::CLI::Resource
         WINGET_DEFINE_RESOURCE_STRINGID(HelpLinkPreamble);
         WINGET_DEFINE_RESOURCE_STRINGID(IdArgumentDescription);
         WINGET_DEFINE_RESOURCE_STRINGID(IgnoreLocalArchiveMalwareScanArgumentDescription);
+        WINGET_DEFINE_RESOURCE_STRINGID(IgnoreWarningsArgumentDescription);
         WINGET_DEFINE_RESOURCE_STRINGID(ImportCommandLongDescription);
         WINGET_DEFINE_RESOURCE_STRINGID(ImportCommandReportDependencies);
         WINGET_DEFINE_RESOURCE_STRINGID(ImportCommandShortDescription);

src/AppInstallerCLIE2ETests/TestData/Manifests/TestWarningManifest.yaml

@@ -1,12 +1,14 @@
-Id: TestWarning.Manifest
-Name: TestWarningManifest
-Version: 1.0.0.0
+PackageIdentifier: TestWarning.Manifest
+PackageName: TestWarningManifest
+PackageVersion: 1.0.0.0
+PackageLocale: en-US
 Publisher: AppInstallerTest
 License: Test
 Installers:
-  - Arch: x86
-    Url: https://localhost:5001/TestKit/AppInstallerTestExeInstaller/AppInstallerTestExeInstaller.exe
-    Sha256: <EXEHASH>
+  - Architecture: x86
+    InstallerUrl: https://localhost:5001/TestKit/AppInstallerTestExeInstaller/AppInstallerTestExeInstaller.exe
+    InstallerSha256: 0000000000000000000000000000000000000000000000000000000000000000
     InstallerType: exe
-    Switches:
-ManifestVersion: 0.1.0
+ShortDescription: This manifest should have only warnings, no errors
+ManifestType: singleton
+ManifestVersion: 1.6.0

src/AppInstallerCLIE2ETests/ValidateCommand.cs

@@ -47,6 +47,29 @@ public void ValidateInvalidManifest()
             Assert.True(result.StdOut.Contains("Manifest validation failed."));
         }
 
+        /// <summary>
+        /// Test validate manifest with warnings.
+        /// </summary>
+        [Test]
+        public void ValidateManifestWithWarnings()
+        {
+            var result = TestCommon.RunAICLICommand("validate", TestCommon.GetTestDataFile("Manifests\\TestWarningManifest.yaml"));
+            Assert.AreEqual(Constants.ErrorCode.ERROR_MANIFEST_VALIDATION_WARNING, result.ExitCode);
+            Assert.True(result.StdOut.Contains("Manifest validation succeeded with warnings."));
+        }
+
+        /// <summary>
+        /// Test validate manifest with warnings suppressed.
+        /// </summary>
+        [Test]
+        public void ValidateManifestSuppressWarnings()
+        {
+            var result = TestCommon.RunAICLICommand("validate", TestCommon.GetTestDataFile("Manifests\\TestWarningManifest.yaml") + " --ignore-warnings");
+            Assert.AreEqual(Constants.ErrorCode.S_OK, result.ExitCode);
+            Assert.False(result.StdOut.Contains("Manifest validation succeeded with warnings."));
+            Assert.True(result.StdOut.Contains("Manifest validation succeeded."));
+        }
+
         /// <summary>
         /// Test validate manifest that doesn't exist.
         /// </summary>

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

@@ -261,6 +261,9 @@ They can be configured through the settings file 'winget settings'.</value>
   <data name="IdArgumentDescription" xml:space="preserve">
     <value>Filter results by id</value>
   </data>
+  <data name="IgnoreWarningsArgumentDescription" xml:space="preserve">
+    <value>Suppresses warning outputs.</value>
+  </data>
   <data name="InstallationDisclaimer1" xml:space="preserve">
     <value>This application is licensed to you by its owner.</value>
   </data>