Skip to content

Restore nightly validation #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kennykerr opened this issue Apr 29, 2022 · 0 comments · Fixed by #1726
Closed

Restore nightly validation #1725

kennykerr opened this issue Apr 29, 2022 · 0 comments · Fixed by #1726
Labels
bug Something isn't working

Comments

@kennykerr
Copy link
Collaborator

kennykerr commented Apr 29, 2022 •
edited
Loading

Looks like the nightly bug related to name mangling has been fixed:

rust-lang/rust#96444

Once its available in nightly, we need to remove the continue-on-error from the build.

The following command can be used to verify the fix:

cargo test -p test_nightly_component --target i686-pc-windows-msvc
@kennykerr kennykerr added the bug Something isn't working label Apr 29, 2022
@riverar riverar mentioned this issue Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore nightly validation microsoft/windows-rs
1 participant
@kennykerr