Skip to content

Terminal Suggest: Default executable extension filter #237596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tyriar opened this issue Jan 9, 2025 · 1 comment · Fixed by #238142 or #238155
Closed

Terminal Suggest: Default executable extension filter #237596

Tyriar opened this issue Jan 9, 2025 · 1 comment · Fixed by #238142 or #238155
Assignees
@meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-suggest
Milestone
January 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2025

We talked about Windows lacking the executable bit and are just showing all extensions currently. It's already annoying me tbh, we should add a default executable files setting on Windows ([] / undefined on mac/linux) so dll, xml`, etc. don't show by default. The majority of the results at the top aren't relevant for me:

Image

This should also improve performance a little as we won't need to create 6000 completion items.
@meganrogge meganrogge added the feature-request Request for new features or functionality label Jan 9, 2025
@meganrogge meganrogge added this to the January 2025 milestone Jan 9, 2025
meganrogge added a commit that referenced this issue Jan 17, 2025
@meganrogge
fix #237596
83f6203
@meganrogge meganrogge mentioned this issue Jan 17, 2025
Merged
meganrogge added a commit that referenced this issue Jan 17, 2025
@meganrogge
check if windows file is executable (#238142)
f1b4bb8 
fix #237596
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 17, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 17, 2025

As discussed let's make a simple setting so suggest isn't completely broken, especially since we're filtering not just deprioritizing the suggestions.

@Tyriar Tyriar reopened this Jan 17, 2025
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jan 17, 2025
@meganrogge meganrogge mentioned this issue Jan 17, 2025
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 17, 2025
@meganrogge meganrogge mentioned this issue Jan 27, 2025
Closed
3 tasks
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-suggest
Projects
None yet
Milestone
January 2025
2 participants
@Tyriar @meganrogge