Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor GPU: Support font-weight in decorations #237584

Closed
Tyriar opened this issue Jan 9, 2025 · 1 comment · Fixed by #237677
Closed

Editor GPU: Support font-weight in decorations #237584

Tyriar opened this issue Jan 9, 2025 · 1 comment · Fixed by #237677
Assignees
@Tyriar
Labels
editor-gpu Editor GPU rendering related issues insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming
Milestone
January 2025

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2025

Example decoration from extension:

Image

  "highlight.regexes": {
    "(\\s(?:TODO|FIXME|DEBT):)\\s": {
      "decorations": [
        {
          "overviewRulerColor": "#cca70060",
          "color": "#cca700",
          "fontWeight": "bold"
        }
      ]
    }
  }

Image
@Tyriar Tyriar added editor-gpu Editor GPU rendering related issues plan-item VS Code - planned item for upcoming labels Jan 9, 2025
@Tyriar Tyriar self-assigned this Jan 9, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 10, 2025

Depends on #234473

Tyriar added a commit that referenced this issue Jan 10, 2025
@Tyriar
Set up for font-weight support on GPU renderer
5bff58f 
Part of #237584
Tyriar added a commit that referenced this issue Jan 10, 2025
@Tyriar
Set up for font-weight support on GPU renderer
2f35e8d 
Part of #237584
This was referenced Jan 10, 2025
Closed
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 10, 2025
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 10, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 13, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
editor-gpu Editor GPU rendering related issues insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming
Projects
VS Code Editor GPU Renderer
Status: Done
Milestone
January 2025
1 participant
@Tyriar