Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor GPU: Double rendering after undo #237583

Open
Tyriar opened this issue Jan 9, 2025 · 8 comments
Open

Editor GPU: Double rendering after undo #237583

Tyriar opened this issue Jan 9, 2025 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2025

Repro:

  1. Enable editor gpu rendering, reload window
  2. Go to this line in vscode:
    export function asArray<T>(x: T | T[]): T[];
    export function asArray<T>(x: T | readonly T[]): readonly T[];
    export function asArray<T>(x: T | T[]): T[] {
    return Array.isArray(x) ? x : [x];
    }
  3. Delete that function
  4. Undo, 🐛 bad render

Image

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues labels Jan 9, 2025
@Tyriar Tyriar added this to the January 2025 milestone Jan 9, 2025
@Tyriar Tyriar self-assigned this Jan 9, 2025
@ShreyasJejurkar
Copy link

how to enable editor gpu rendering in vs code insiders? I don't find any doc or issue about it.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2025

@ShreyasJejurkar #221145 is the main issue, in the very latest insiders (the one released today) you should see this setting now:

Image

Keep in mind the focus for now is on stability and feature completeness over performance though.

@ShreyasJejurkar
Copy link

Thanks for this @Tyriar . Any idea when it would be released to border audience?

@Tyriar
Copy link
Member Author

Tyriar commented Jan 20, 2025

@ShreyasJejurkar I answered this a while ago in #221145 (comment), still have some big functionality parts to add but getting towards the Focus on performance phase.

@ShreyasJejurkar
Copy link

I enabled this setting, but I got the below popup.

Image

@Tyriar
Copy link
Member Author

Tyriar commented Jan 21, 2025

@ShreyasJejurkar are you on Linux or a VM, when you hit that it typically means Chromium/Electron has your hardware/environment in their gpu blacklist.

@ShreyasJejurkar
Copy link

@ShreyasJejurkar are you on Linux or a VM, when you hit that it typically means Chromium/Electron has your hardware/environment in their gpu blacklist.

I am on Windows 10 and my work PC has Intel XE Graphics. I don't see this issue on my personal laptop which is having RTX 4070 GPU.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 21, 2025

@ShreyasJejurkar if you run the command Developer: Show GPU Info via the command palette it should say why webgpu isn't enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-gpu Editor GPU rendering related issues
Projects
Status: No status
Development

No branches or pull requests

2 participants