auto type acquisition doesn't kick in without --save

[mousetraps]

• VSCode Version: Code 1.7.2 (7ba55c5, 2016-11-21T22:06:37.428Z)
• OS Version: Windows_NT ia32 10.0.14931

Steps to Reproduce:

1. remove underscore from %localappdata%/TypeScript/package.json and from corresponding node_modules
2. open a Node project that does not have underscore installed (e.g. https://github.com/Microsoft/vscode-smoketest-express.git). VSCode will subsequently install type-registry, and any @types associated with the project.
3. npm install underscore

Expected: underscore is installed, as are associated types, even though it doesn't exist in package.json
Actual: types are not installed

Note that reloading the project altogether yields the expected behavior.

[dbaeumer]

@waderyan looks like a TS issue to me.

[mjbvz]

This discussion on the TS side tracks a somewhat related design consideration: microsoft/TypeScript#11917

I believe this is currently the expected behavior, but I'll go ahead and open a issue against TS to see if this is the correct design. In the simple npm install X case, it probably makes sense to download the typings, but would would also want to make sure we don't install unnecessary typings for second level+ dependencies.

[mjbvz]

After more investigation, I found that we do acquire typings in this case, but only after we trigger a project update in some way (for example, editing a file):

In the --save case, we always install the typings. In the regular install case, it seems the typings are only installed after I edit and save a file or reload the project. It could be that the --save case is automatically sending some edit action to the server which triggers the typing acquisition, or TS could be handling this differently.

[waderyan]

Closing in this end as this issue is tracked in TS's repo.