Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect source-map work when VS Code and sources located on different disk(Windows) #492

Closed
itoys opened this issue Jul 27, 2017 · 3 comments
Milestone

Comments

@itoys
Copy link
Contributor

itoys commented Jul 27, 2017

Actual Behavior

Breakpoints in TS code don't work if VS Code and sources located on different disk

Expected Behavior

Breakpoints work correct

@itoys
Copy link
Contributor Author

itoys commented Jul 27, 2017

Problem with our dependencies lydell/source-map-resolve#9

@lydell
Copy link

lydell commented Jul 28, 2017

Is the source-map-resolve package helpful to you? I'm not sure that source-map-resolve is a good abstraction anymore. If it is to you we can try to fix things. Otherwise it might be worth having source-map-resolve as a reference while implementing something on your own.

@vladimir-kotikov
Copy link
Contributor

Fixed in #493

Thanks for suggestion, Simon (@lydell) - we'll definitely look at rewriting sourcemaps resolution logic to not depend on external components, but in the meantime this patch should unblock Windows users experiencing the issue.

@vladimir-kotikov vladimir-kotikov added this to the 0.4.1 milestone Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants