Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email address for merge commit is not remembered (and cannot be set) #6593

Open
frossie opened this issue Jan 10, 2025 · 0 comments
Open

Email address for merge commit is not remembered (and cannot be set) #6593

frossie opened this issue Jan 10, 2025 · 0 comments

Comments

@frossie
Copy link

frossie commented Jan 10, 2025

Following from #5326 which added the ability to choose the e-mail address associated with a merge commit (thank you!)

Problem: if you want a different value (for the e-mail to be associated with your merge commit,) than the one the extension defaults to, you have to change it every time.

  • Ideally, the e-mail selected would default to the one configured in the local git repository

As is, if you have made commits from eg. your work computer and you forget to switch out the email associated with the merge commit (that seems to default to the on your personal Github profile) you end up with the merge commit being with a different e-mail than the rest of your commits. The best option is for the extension to default to the email that matches the git config user.email (provided it matches one of the email addresses returned by the Github API of course)

  • Alternatively, the extension could default to the last value chosen in the extension

This is the behavior of the Github UI and probably deals with the vast majority of annoyances.

  • Or, it could be settable as an extension property

This is less than ideal because of people who do open source and employer commits under separate e-mails from the same environment, but it would be an improvement on the current situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant