Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use flag to turn on (Namespace = namespace) feature #5534

Closed
JoshLove-msft opened this issue Jan 8, 2025 · 2 comments
Closed

Do not use flag to turn on (Namespace = namespace) feature #5534

JoshLove-msft opened this issue Jan 8, 2025 · 2 comments
Assignees
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

If we are saying that Typespec namespace should correspond to csharp namespace, then this feature should not be behind a flag. It should just work that way. Otherwise, specs become very difficult to reason about as the emitter can essentially change the interpretation of what is actually a TypeSpec keyword.

@markcowl markcowl added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jan 8, 2025
@ArcturusZhang
Copy link
Member

I think we will not add such a flag in our csharp generator.
is this issue here to notify us that we do not add this?

@JoshLove-msft
Copy link
Contributor Author

JoshLove-msft commented Jan 13, 2025

Yes, this was opened to suggest that we not add this flag for the csharp generator. @ArcturusZhang, feel free to close this as part of your namespace implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

No branches or pull requests

3 participants