-
Notifications
You must be signed in to change notification settings - Fork 9k
Open
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.
Milestone
Description
work branch https://github.com/microsoft/terminal/tree/dev/duhowett/m.t.ui
We have some UI helpers flung all about the Terminal code, including in Terminal.Settings.Model, that could be consolidated.
- TerminalApp
EmptyStringVisibilityConverter
- TerminalSettingsEditor
Converters- Including a duplicate
EmptyStringVisibilityConverterequivalent; deduplicate these!
- Including a duplicate
- TerminalSettingsModel
IconPathConverter
I originally authored it to contain a resource string markup extension as detailed in an APS blog post. That'll help us get rid of all the places where we load resource strings in code because they couldn't be bound in XAML.
Metadata
Metadata
Assignees
Labels
Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.The new Windows Terminal.