Skip to content

Consider consolidating UI helpers into a Microsoft.Terminal.UI namespace/dll #15058

@DHowett

Description

@DHowett

work branch https://github.com/microsoft/terminal/tree/dev/duhowett/m.t.ui

We have some UI helpers flung all about the Terminal code, including in Terminal.Settings.Model, that could be consolidated.

  • TerminalApp
    • EmptyStringVisibilityConverter
  • TerminalSettingsEditor
    • Converters
      • Including a duplicate EmptyStringVisibilityConverter equivalent; deduplicate these!
  • TerminalSettingsModel
    • IconPathConverter

I originally authored it to contain a resource string markup extension as detailed in an APS blog post. That'll help us get rid of all the places where we load resource strings in code because they couldn't be bound in XAML.

Metadata

Metadata

Assignees

Labels

Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions