[Feature Request]: C#: remove history from DefaultTempState #1020
Assignees
Labels
dotnet
Change/fix applies to dotnet. If all three, use the 'JS & dotnet & Python' label
enhancement
New feature or request
Comments
corinagum
added
enhancement
1 task
singhk97
pushed a commit
that referenced
this issue
Dec 6, 2023
## Linked issues closes: #1020 ## Details Align with JS changes to remove `History` from default temp state. It seems there's already 0 reference on `TempState.History` so safe to remove. #### Change details - Remove `History` and `HistoryKey` from temp state - No unit test reference - No sample reference ## Attestation Checklist - [X] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (we use [TypeDoc](https://typedoc.org/) to document our code) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes ### Additional information > Feel free to add other relevant information below
singhk97
pushed a commit
that referenced
this issue
Dec 6, 2023
## Linked issues closes: #1020 ## Details Align with JS changes to remove `History` from default temp state. It seems there's already 0 reference on `TempState.History` so safe to remove. #### Change details - Remove `History` and `HistoryKey` from temp state - No unit test reference - No sample reference ## Attestation Checklist - [X] My code follows the style guidelines of this project - I have checked for/fixed spelling, linting, and other errors - I have commented my code for clarity - I have made corresponding changes to the documentation (we use [TypeDoc](https://typedoc.org/) to document our code) - My changes generate no new warnings - I have added tests that validates my changes, and provides sufficient test coverage. I have tested with: - Local testing - E2E testing in Teams - New and existing unit tests pass locally with my changes ### Additional information > Feel free to add other relevant information below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please see PR: #913
historyhas been removed from temp state. Please make the equivalent changes for C#. Thanks!The text was updated successfully, but these errors were encountered: