Remove TraceHelper.Trace calls that emit Azure resource IDs from AzureKeyVaultHelper and AzureStorageHelper

David Shiflet · David Shiflet · commit 686fff2d3673 · 2026-02-13T16:10:31.000-06:00
diff --git a/src/FunctionalTest/Framework/Helpers/AzureKeyVaultHelper.cs b/src/FunctionalTest/Framework/Helpers/AzureKeyVaultHelper.cs
@@ -77,7 +77,6 @@ public string GetDecryptedSecret(string secretName)
             }
             if (string.IsNullOrEmpty(secret))
             {
-                TraceHelper.TraceInformation("Looking for secret {0} using name {1}. Starting with environment variables.", secretName, lookupName);
                 secret = Environment.GetEnvironmentVariable(lookupName);
             }
             if (string.IsNullOrEmpty(secret))
@@ -89,7 +88,6 @@ public string GetDecryptedSecret(string secretName)
                     secretClient = new SecretClient(new Uri($"https://{KeyVaultName}.vault.azure.net"), credential);
                 }
                 var secretIdentifier = $"https://{KeyVaultName}.vault.azure.net/secrets/{lookupName}";
-                TraceHelper.TraceInformation("Secret {0} not set as environment variable. Looking in AKV for {1}.", secretName, secretIdentifier);
                 try
                 {
                     secret = secretClient.GetSecret(lookupName).Value.Value;
@@ -193,7 +191,6 @@ private static bool DetectAzureVM()
         /// <returns></returns>
         public string GetStorageAccountAccessKey(string storageAccountResourceId)
         {
-            TraceHelper.TraceInformation($"Fetching storage access key for {storageAccountResourceId}");
             return new AzureStorageHelper(storageAccountResourceId, this).GetStorageAccountAccessKey(storageAccountResourceId);
         }
     }
diff --git a/src/FunctionalTest/Framework/Helpers/AzureStorageHelper.cs b/src/FunctionalTest/Framework/Helpers/AzureStorageHelper.cs
@@ -38,7 +38,6 @@ public Credential EnsureCredential(Management.Smo.Server server)
 
         public string GetStorageAccountAccessKey(string storageAccountResourceId)
         {
-            TraceHelper.TraceInformation($"Fetching storage access key for {storageAccountResourceId}");
             var storageAccount = ArmClient.GetStorageAccountResource(new Azure.Core.ResourceIdentifier(storageAccountResourceId));
             return storageAccount.GetKeys().First().Value;
         }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ public string GetDecryptedSecret(string secretName)`
`77`	`77`	`}`
`78`	`78`	`if (string.IsNullOrEmpty(secret))`
`79`	`79`	`{`
`80`		`- TraceHelper.TraceInformation("Looking for secret {0} using name {1}. Starting with environment variables.", secretName, lookupName);`
`81`	`80`	`secret = Environment.GetEnvironmentVariable(lookupName);`
`82`	`81`	`}`
`83`	`82`	`if (string.IsNullOrEmpty(secret))`
`@@ -89,7 +88,6 @@ public string GetDecryptedSecret(string secretName)`
`89`	`88`	`secretClient = new SecretClient(new Uri($"https://{KeyVaultName}.vault.azure.net"), credential);`
`90`	`89`	`}`
`91`	`90`	`var secretIdentifier = $"https://{KeyVaultName}.vault.azure.net/secrets/{lookupName}";`
`92`		`- TraceHelper.TraceInformation("Secret {0} not set as environment variable. Looking in AKV for {1}.", secretName, secretIdentifier);`
`93`	`91`	`try`
`94`	`92`	`{`
`95`	`93`	`secret = secretClient.GetSecret(lookupName).Value.Value;`
`@@ -193,7 +191,6 @@ private static bool DetectAzureVM()`
`193`	`191`	`/// <returns></returns>`
`194`	`192`	`public string GetStorageAccountAccessKey(string storageAccountResourceId)`
`195`	`193`	`{`
`196`		`- TraceHelper.TraceInformation($"Fetching storage access key for {storageAccountResourceId}");`
`197`	`194`	`return new AzureStorageHelper(storageAccountResourceId, this).GetStorageAccountAccessKey(storageAccountResourceId);`
`198`	`195`	`}`
`199`	`196`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ public Credential EnsureCredential(Management.Smo.Server server)`
`38`	`38`
`39`	`39`	`public string GetStorageAccountAccessKey(string storageAccountResourceId)`
`40`	`40`	`{`
`41`		`- TraceHelper.TraceInformation($"Fetching storage access key for {storageAccountResourceId}");`
`42`	`41`	`var storageAccount = ArmClient.GetStorageAccountResource(new Azure.Core.ResourceIdentifier(storageAccountResourceId));`
`43`	`42`	`return storageAccount.GetKeys().First().Value;`
`44`	`43`	`}`