[rush] "rush add" should be able to add unpublished locally-linked projects

[cortopy]

I come from the lerna world, and I can't get my head round the fact that you can't add -p <package> when that package is internal and has not been published yet.

When you do lerna add it will first check the npm registry, and if none available it will check if it's one of the packages in the monorepo.

For now, I'm adding a line in the package.json of each file. But this forces me to do rush update -p --full each time, which is cumbersome.

How does one link dependencies within the monorepo itself with Rush? If there's a way I'd love to know. If not, I'd love something like lerna even more

The only information I could find about linking packages is this issue and the solution does not seem to be supported in rushjs 5.

[octogonz]

I come from the lerna world, and I can't get my head round the fact that you can't add -p <package> when that package is internal and has not been published yet.

Hmmm... We don't use Lerna regularly, so when we designed the rush add feature we hadn't thought about this case at all. But it seems obvious enough that we decided to tag it as a "bug" instead of an "enhancement". :-)

For now, I'm adding a line in the package.json of each file. But this forces me to do rush update -p --full each time, which is cumbersome.

Are you sure? The --purge option generally should be needed only if your common/temp folder got corrupted somehow. And the --full option is generally needed only if you're intentionally wanting to do a global update. rush update should work in this situation and should be pretty fast.

Which package manager are you using with Rush?

How does one link dependencies within the monorepo itself with Rush?

It happens automatically. If a project registered in rush.json satisfies the SemVer range for a dependency, it will get locally linked. The only exception is when cyclicDependencyProjects is used. (See issue #547 for some additional thoughts about that.)

[octogonz]

@nickpape-msft FYI

[cortopy]

thanks @pgonzal for looking into this!!

Are you sure? The --purge option generally should be needed only if your common/temp folder got corrupted somehow. And the --full option is generally needed only if you're intentionally wanting to do a global update. rush update should work in this situation and should be pretty fast.

I was getting a lot of Unhandled rejection Error: Integrity check failed: errors when not running with those options. I'm not sure what I was doing wrong, as I'm still trying to understand what each command and option does

Which package manager are you using with Rush?

npm v6.5.0

[octogonz]

I was getting a lot of Unhandled rejection Error: Integrity check failed: errors when not running with those options. I'm not sure what I was doing wrong, as I'm still trying to understand what each command and option does

Which package manager are you using with Rush?

npm v6.5.0

Sounds like the same issue as #886 . We do need to get this fixed. But it seems like every time a person comes along who's excited to pitch in and improve the NPM support, they end up switching to PNPM or Yarn. Even the NPM developer seemed to lose interest in fixing the regression discussed in that thread.

[cortopy]

In my case I started with PNPM but it was giving me so many issues I decided to stick with what I know (either npm or yarn. I read yarn support is still experimental so picked npm). I was hitting my limit of fixing issues related to new tooling and I rather focus on one thing (i.e.: rush)

[octogonz]

@WanderWang encountered this in a Gitter chat today.

[halfnibble]

We tried to repro this today using rush add -p <local-package> and it just worked. We used pnpm version 3. Also note, the local package was listed in the rush.json config (which I don't think is an unreasonable assumption). @WanderWang can you link us to your repo or can someone send us a minimal repro?