-
Notifications
You must be signed in to change notification settings - Fork 663
Open
Description
Summary
rush-pnpm approve-builds does not update common/config/rush/pnpm-config.json, which means the user is presented with the same warning on every rush update.
Repro steps
- Upgrade to the latest version of Node and pnpm
- Run
rush updatein a repo where dependencies have build scripts - See the warning about "Ignored build scripts"
- Run
rush-pnpm approve-buildsand approve the dependencies - Run
rush updateagain - See that the warning still appears
Expected result: Warning should go away
Actual result: Warning continues to appear
Details
See #5542 also.
Standard questions
Please answer these questions to help us investigate your issue more quickly:
| Question | Answer |
|---|---|
@microsoft/rush globally installed version? |
5.165.0 |
rushVersion from rush.json? |
5.165.0 |
pnpmVersion, npmVersion, or yarnVersion from rush.json? |
[email protected] |
(if pnpm) useWorkspaces from pnpm-config.json? |
true |
| Operating system? | Windows 11 |
| Would you consider contributing a PR? | No |
Node.js version (node -v)? |
24.12.0 |
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Needs triage