Merge pull request #4684 from aramissennyeydd/sennyeya/weighting-bug-fix

bug(rush-lib,operation-weighting): UNASSIGNED_OPERATION causing memory leak

Author: iclanton

common/changes/@microsoft/rush/sennyeya-weighting-bug-fix_2024-05-08-13-35.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fixes a bug where cobuilds would cause a GC error when waiting for long periods of time.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/operations/AsyncOperationQueue.ts

@@ -17,7 +17,7 @@ export const UNASSIGNED_OPERATION: 'UNASSIGNED_OPERATION' = 'UNASSIGNED_OPERATIO
 
 export type IOperationIteratorResult =
   | OperationExecutionRecord
-  | { weight: 0; status: typeof UNASSIGNED_OPERATION };
+  | { weight: 1; status: typeof UNASSIGNED_OPERATION };
 
 /**
  * Implementation of the async iteration protocol for a collection of IOperation objects.
@@ -166,7 +166,7 @@ export class AsyncOperationQueue
       // remote executing operation which is not ready to process.
       if (queue.some((operation) => operation.status === OperationStatus.RemoteExecuting)) {
         waitingIterators.shift()!({
-          value: { weight: 0, status: UNASSIGNED_OPERATION },
+          value: { weight: 1, status: UNASSIGNED_OPERATION },
           done: false
         });
       }