Skip to content

Commit 343e98b

Browse files
committed
Address PR feedback
1 parent d49f027 commit 343e98b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

libraries/rush-lib/src/logic/operations/ShellOperationRunner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class ShellOperationRunner implements IOperationRunner {
7373
let hasWarningOrError: boolean = false;
7474

7575
// Run the operation
76-
terminal.writeLine('Invoking: ' + this._commandToRun);
76+
terminal.writeLine(`Invoking: ${this._commandToRun}`);
7777

7878
const { rushConfiguration, projectFolder } = this._rushProject;
7979

libraries/rush-lib/src/logic/operations/ShellOperationRunnerPlugin.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ export function initializeShellOperationRunner(options: {
9999
}
100100

101101
if (rawCommandToRun) {
102-
const { commandForHash: rawCommandForHash } = options;
102+
const { commandForHash: rawCommandForHash, environment, customParameterValues } = options;
103103

104-
const commandToRun: string = formatCommand(rawCommandToRun, options.customParameterValues);
104+
const commandToRun: string = formatCommand(rawCommandToRun, customParameterValues);
105105
const commandForHash: string = rawCommandForHash
106-
? formatCommand(rawCommandForHash, options.customParameterValues)
106+
? formatCommand(rawCommandForHash, customParameterValues)
107107
: commandToRun;
108108

109109
return new ShellOperationRunner({
@@ -112,7 +112,7 @@ export function initializeShellOperationRunner(options: {
112112
displayName,
113113
phase,
114114
rushProject: project,
115-
environment: options.environment
115+
environment
116116
});
117117
} else {
118118
// Empty build script indicates a no-op, so use a no-op runner

0 commit comments

Comments
 (0)